Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix providing Ditto Adaptable information in the "_context" of an SSE event #1716

Merged
merged 1 commit into from
Aug 11, 2023
Merged

fix providing Ditto Adaptable information in the "_context" of an SSE event #1716

merged 1 commit into from
Aug 11, 2023

Conversation

thjaeckle
Copy link
Member

Previously, the optional _context of a SSE subscription only contained the headers.

For the NormalizedMessageMapper of connectivity, however, also additional information from the Ditto Adpatable is provided, like:

  • topic
  • path

This PR adds this information as well for the SSE _context and fixes that the headers included Ditto internal headers which should not be exposed.

@thjaeckle thjaeckle added this to the 3.3.6 milestone Aug 11, 2023
alstanchev
alstanchev approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@alstanchev alstanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thjaeckle thjaeckle merged commit 5840592 into master Aug 11, 2023
@thjaeckle thjaeckle deleted the bugfix/sse-context branch August 11, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alstanchev alstanchev alstanchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Ditto Planning
Status: Done
Milestone
3.3.6
Development

Successfully merging this pull request may close these issues.
2 participants
@thjaeckle @alstanchev