-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide Helm chart in Ditto repository #1635
Conversation
6288f68
to
a481688
Compare
@kalinkostashki and @alstanchev any feedback on this WIP addition of the Helm chart to the Ditto repo is welcome. As I mentioned I would like to publish to Docker Hub which is an OCI-based registry. |
f5d10e7
to
90a518a
Compare
* initially migrated from IoT Packages project * however enhanced with a lot more configuration options in order to be the basis for a productive Helm chart * also added quite advanced ingress configuration Signed-off-by: Thomas Jäckle <[email protected]>
cc8e7a6
to
d2155fb
Compare
…lm chart on Helm chart changes Signed-off-by: Thomas Jäckle <[email protected]>
Signed-off-by: Thomas Jäckle <[email protected]>
Signed-off-by: Thomas Jäckle <[email protected]>
Signed-off-by: Thomas Jäckle <[email protected]>
Signed-off-by: Thomas Jäckle <[email protected]>
Signed-off-by: Thomas Jäckle <[email protected]>
Signed-off-by: Thomas Jäckle <[email protected]>
Signed-off-by: Thomas Jäckle <[email protected]>
…ions Signed-off-by: Thomas Jäckle <[email protected]>
FMPOV this PR is ready to be reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added few comments, the autocorrect probably was playing smart :)
Signed-off-by: Thomas Jäckle <[email protected]>
Thx @alstanchev - that mainly was "copy & paste" from the previous Helm chart readme - which already contained the issues as well ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Open:
values.yaml
for details on the config options)I suggest to use Docker Hub OCI registry to publish the Helm chart - that however needs some investigation how to do via GitHub action, e.g. look into: