Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Helm chart in Ditto repository #1635

Merged
merged 11 commits into from
Jun 13, 2023
Merged

Provide Helm chart in Ditto repository #1635

merged 11 commits into from
Jun 13, 2023

Conversation

thjaeckle
Copy link
Member

@thjaeckle thjaeckle commented May 15, 2023

  • initially migrated from IoT Packages project
  • however enhanced with a lot more configuration options in order to be the basis for a productive Helm chart
  • also added quite advanced ingress configuration

Open:

  • provide building (CI, linting, etc.) of the Helm chart
  • provide packaging and publishing of the Helm chart (I created a new Docker repository for that purpose: https://hub.docker.com/r/eclipse/ditto)
  • adjust deployment documentation (link to values.yaml for details on the config options)

I suggest to use Docker Hub OCI registry to publish the Helm chart - that however needs some investigation how to do via GitHub action, e.g. look into:

@thjaeckle thjaeckle added this to the 3.3.0 milestone May 15, 2023
@thjaeckle thjaeckle force-pushed the helm-chart branch 3 times, most recently from 6288f68 to a481688 Compare May 15, 2023 14:16
@thjaeckle
Copy link
Member Author

@kalinkostashki and @alstanchev any feedback on this WIP addition of the Helm chart to the Ditto repo is welcome.

As I mentioned I would like to publish to Docker Hub which is an OCI-based registry.

@thjaeckle thjaeckle force-pushed the helm-chart branch 3 times, most recently from f5d10e7 to 90a518a Compare May 15, 2023 17:44
* initially migrated from IoT Packages project
* however enhanced with a lot more configuration options in order to be the basis for a productive Helm chart
* also added quite advanced ingress configuration

Signed-off-by: Thomas Jäckle <[email protected]>
@thjaeckle thjaeckle force-pushed the helm-chart branch 2 times, most recently from cc8e7a6 to d2155fb Compare May 18, 2023 19:25
…lm chart on Helm chart changes

Signed-off-by: Thomas Jäckle <[email protected]>
@thjaeckle thjaeckle marked this pull request as ready for review May 22, 2023 16:18
@thjaeckle
Copy link
Member Author

FMPOV this PR is ready to be reviewed.
Publishing the Helm chart can only be tested after merging the PR - when there are errors, I can provide a fix.

Copy link
Contributor

@alstanchev alstanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added few comments, the autocorrect probably was playing smart :)

Signed-off-by: Thomas Jäckle <[email protected]>
@thjaeckle
Copy link
Member Author

Thx @alstanchev - that mainly was "copy & paste" from the previous Helm chart readme - which already contained the issues as well ;)
I fixed them ..

@thjaeckle thjaeckle self-assigned this May 23, 2023
Copy link
Contributor

@kalinkostashki kalinkostashki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@thjaeckle thjaeckle merged commit 330a4ab into master Jun 13, 2023
@thjaeckle thjaeckle deleted the helm-chart branch June 14, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants