Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[development,docs]: build_images.sh fails if ditto-ui wasn't build before #1699

Closed
Altair-Bueno opened this issue Jul 20, 2023 · 0 comments · Fixed by #1837
Closed

[development,docs]: build_images.sh fails if ditto-ui wasn't build before #1699

Altair-Bueno opened this issue Jul 20, 2023 · 0 comments · Fixed by #1837
Assignees
@thjaeckle
Milestone
3.5.0

Comments

@Altair-Bueno
Copy link
Contributor

The steps described on the readme for building ditto for development are out of date.

ditto/README.md

Line 80 in 022dffe

#### 1. Build Ditto with Maven
.

Possible solutions:

  1. Provide an option on build_images.sh to disable building certain components (e.g. ditto-ui)
  2. Use a multi-stage docker build https://docs.docker.com/build/building/multi-stage/
  3. Ask the the developer to build the ui before running build_images.sh. npm i -C ui && npm run build -C ui

Personally I would prefer options 1 or 2, less burden for new contributors. But the one liner should be fine too if the developer has a compatible node & npm version already installed.
@thjaeckle thjaeckle mentioned this issue Dec 8, 2023
Closed
thjaeckle added a commit that referenced this issue Dec 8, 2023
@thjaeckle
#1699 made building the Ditto UI image optional and configurable in b…
5346e2c 
…uild-images.sh

Signed-off-by: Thomas Jäckle <[email protected]>
@thjaeckle thjaeckle mentioned this issue Dec 8, 2023
Merged
@thjaeckle thjaeckle added this to the 3.5.0 milestone Dec 8, 2023
@thjaeckle thjaeckle moved this to Waiting for Approval in Ditto Planning Dec 8, 2023
thjaeckle added a commit that referenced this issue Dec 8, 2023
@thjaeckle
Merge pull request #1837 from eclipse-ditto/make-building-ui-docker-i…
ee9555d 
…mage-configurable

#1699 made building the Ditto UI image optional and configurable in build-images.sh
@github-project-automation github-project-automation bot moved this from Waiting for Approval to Done in Ditto Planning Dec 8, 2023
@thjaeckle thjaeckle self-assigned this Dec 8, 2023
thfries pushed a commit to thfries/ditto that referenced this issue Jan 13, 2024
@thjaeckle @thfries
eclipse-ditto#1699 made building the Ditto UI image optional and conf…
9670c66 
…igurable in build-images.sh

Signed-off-by: Thomas Jäckle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thjaeckle thjaeckle

Labels
None yet
Projects
Ditto Planning
Status: Done
Milestone
3.5.0
2 participants
@thjaeckle @Altair-Bueno