re-check reconnecting state before emitting

[kalinkostashki]

• since the connectExecutor thread starts a reconnect which in turn causes the websocket connection to go into onConnected() method in the default(callback). This can cause an emit of message before reconnecting boolean is set to false
• introduced a mechanism in order to make sure and retry several times to get the correct value

Fixes: #231

[thjaeckle]

@kalinkostashki thanks - I left some remarks. :)
I think this solution should work fixing the problem you observed - good catch. 👍

[kalinkostashki]

@kalinkostashki thanks - I left some remarks. :) I think this solution should work fixing the problem you observed - good catch. 👍
@thjaeckle
done :)
I do have a question though:

for line 375 where I catch the InterruptedException I'm not quite sure how to handle it.
Should I rethrow it ? Or maybe interrupt the thread but that has its own implications?

[thjaeckle]

@kalinkostashki thanks - I left some remarks. :) I think this solution should work fixing the problem you observed - good catch. 👍
@thjaeckle
done :)
I do have a question though:

for line 375 where I catch the InterruptedException I'm not quite sure how to handle it. Should I rethrow it ? Or maybe interrupt the thread but that has its own implications?

Yeah - normally the "correct" thing is to do Thread.currentThread().interrupt(); in the catch block for InterruptedException.
Should work also here, I assume.

[thjaeckle]

@kalinkostashki do you want to add that Thread interruption?

[thjaeckle]

LGTM 👍

Thanks for the fix @kalinkostashki