Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent completion assist in comments #79

Open
dc740 opened this issue May 27, 2018 · 1 comment
Open

Prevent completion assist in comments #79

dc740 opened this issue May 27, 2018 · 1 comment
Labels
upstream-rls Issues requiring work in the Rust Language Server. Those issues should link to RLS issues.

Comments

@dc740
Copy link

dc740 commented May 27, 2018 •
edited
Loading

This is a suggestion. The completion assist is shown even inside of the comment sections.

Reproduce steps:

  1. Add a comment (// or /**/. it doesn't matter)
  2. Write some description, type in a dot (.) and try to continue with your documentation

Expected result:

  • There shouldn't be any suggestions

Actual result:

  • There are suggestions to autocomplete the "code".
@mickaelistria mickaelistria mentioned this issue May 28, 2018
Open
@mickaelistria mickaelistria added the upstream-rls Issues requiring work in the Rust Language Server. Those issues should link to RLS issues. label May 28, 2018
@mickaelistria
Copy link
Contributor

I believe it's an issue with RLS that's used by corrosion. Opened rust-lang/rls#882 to RLS

LucasBullen pushed a commit to LucasBullen/corrosion that referenced this issue Jun 1, 2018
eclipse-corrosion#23 - Snippet Prefernces & eclipse-corrosion#79 - Pr…
f4c462b 
…event competion assist in comments

 - Use the Template system to store/edit/input old snippets
 - Only allow adding templates outside of comments

Signed-off-by: Lucas Bullen <[email protected]>
LucasBullen pushed a commit to LucasBullen/corrosion that referenced this issue Jun 1, 2018
eclipse-corrosion#23 - Snippet Prefernces & eclipse-corrosion#79 - Pr…
ff154ba 
…event competion assist in comments

 - Use the Template system to store/edit/input old snippets
 - Only allow adding templates outside of comments

Signed-off-by: Lucas Bullen <[email protected]>
LucasBullen pushed a commit to LucasBullen/corrosion that referenced this issue Jun 4, 2018
eclipse-corrosion#79 - Prevent competion assist in comments
f4ed58d 
 - Check to see if the cursor is in a Rust comment or not before
returning snippet completions

Signed-off-by: Lucas Bullen <[email protected]>
LucasBullen pushed a commit to LucasBullen/corrosion that referenced this issue Jun 4, 2018
eclipse-corrosion#79 - Prevent competion assist in comments
6bca4db 
 - Check to see if the cursor is in a Rust comment or not before
returning snippet completions

Signed-off-by: Lucas Bullen <[email protected]>
LucasBullen pushed a commit that referenced this issue Jun 5, 2018
#79 - Prevent competion assist in comments
89fe281 
 - Check to see if the cursor is in a Rust comment or not before
returning snippet completions

Signed-off-by: Lucas Bullen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream-rls Issues requiring work in the Rust Language Server. Those issues should link to RLS issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mickaelistria @dc740