Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up org.eclipse.che.selenium.debugger package #6482

Closed
wants to merge 2 commits into from
Closed

Clean up org.eclipse.che.selenium.debugger package #6482

wants to merge 2 commits into from

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Sep 28, 2017

Clean up org.eclipse.che.selenium.debugger package

[TEST] RESULTS ANALYSE:
[TEST]
[TEST] Command line: /home/tolusha/projects/che/selenium/che-selenium-test/selenium-tests.sh --test=org.eclipse.che.selenium.debugger.* --threads=2
[TEST]
[TEST] Local results:
[TEST] 	- Run: 	     24
[TEST] 	- Failed:     4
[TEST]
[TEST] REGRESSION (4):
[TEST] 	org.eclipse.che.selenium.debugger.CppProjectDebuggingTest.shouldDebugCppProject
[TEST] 	org.eclipse.che.selenium.debugger.CppProjectDebuggingTest.stopDebug
[TEST] 	org.eclipse.che.selenium.debugger.PhpProjectDebuggingTest.shouldDebugCliPhpScriptFromFirstLine
[TEST] 	org.eclipse.che.selenium.debugger.PhpProjectDebuggingTest.shouldDebugWebPhpScriptFromNonDefaultPortAndNotFromFirstLine
[TEST]
[TEST]
[TEST]

@tolusha tolusha self-assigned this Sep 28, 2017
@tolusha tolusha requested a review from dmytro-ndp September 28, 2017 11:19
@tolusha tolusha requested a review from vparfonov as a code owner September 28, 2017 11:19
@dmytro-ndp
Copy link
Contributor

@tolusha: why did you remove tests?

@tolusha
Copy link
Contributor Author

tolusha commented Sep 28, 2017

Due to #6480 they won't be fixed

dmytro-ndp
dmytro-ndp requested changes Sep 28, 2017
View reviewed changes
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remain those tests - they will ensure that Che with help of VS Code works with JRE classes and method local inner classes properly.

@tolusha tolusha closed this Sep 28, 2017
@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3874/

@tolusha tolusha deleted the fixCheSuite branch October 3, 2017 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp requested changes

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees

@tolusha tolusha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tolusha @dmytro-ndp @codenvy-ci