Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handlers for websocket connection error and closed #3410

Merged
merged 1 commit into from
Dec 16, 2016
Merged

Conversation

ashumilova
Copy link
Contributor

What does this PR do?

Adds ability to register handlers for websocket connection closed and error events. On workspace creation page, where statuses are tracked, the notification popup will appear if websocket connection closes during status tracking.

What issues does this PR fix or reference?

#3109

Signed-off-by: Ann Shumilova [email protected]

@ashumilova ashumilova added this to the 5.0.0-M9 milestone Dec 16, 2016
@ashumilova ashumilova self-assigned this Dec 16, 2016
@codenvy-ci
Copy link

Build # 1343 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1343/ to view the results.

@ashumilova ashumilova merged commit ae5bcbf into master Dec 16, 2016
@ashumilova ashumilova deleted the CHE-3109 branch December 16, 2016 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants