Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-3257: display version number in CHE dashboard #3365

Merged
merged 1 commit into from
Dec 13, 2016
Merged

Conversation

ashumilova
Copy link
Contributor

What does this PR do?

Adds Che product version to be displayed in footer.

What issues does this PR fix or reference?

#3257

Signed-off-by: Ann Shumilova [email protected]

@ashumilova ashumilova merged commit f3ee2a4 into master Dec 13, 2016
@ashumilova ashumilova deleted the CHE-3257 branch December 13, 2016 11:20
@codenvy-ci
Copy link

Build # 1304 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1304/ to view the results.

@TylerJewell
Copy link

It is usually customary to also include the build # in the version as well in a footer. Do we have that information?

@benoitf
Copy link
Contributor

benoitf commented Dec 13, 2016

we have kind of build number (scm revision) as part of the API

$ curl -X OPTIONS http://localhost:8080/api/
{"scmRevision":"5be04c1775a6ec80c5eccb8562842cc2e8697a72","specificationTitle":"Codenvy REST API","specificationVersion":"1.0-beta2","implementationVendor":"Codenvy, S.A.","specificationVendor":"Codenvy, S.A.","implementationVersion":"5.0.0-M9-SNAPSHOT"}

we may ask version remotely directly from API instead of adding version into product.json file

@ashumilova
Copy link
Contributor Author

+1 on reworking PR and requesting API version instead of modifying product.json files by maven task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants