Fixes #2728: Respect user settings when sending formatting options to LS #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… options to LS Signed-off-by: Kaloyan Raev <[email protected]>
|
ci-build |
benoitf
added
kind/enhancement
|
Can one of the admins verify this patch? |
|
Build # 661 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/661/ to view the results. |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
… options to LS (eclipse-che#2735) * Fixes eclipse-che#2728: Respect user settings when sending formatting options to LS Signed-off-by: Kaloyan Raev <[email protected]> * Remove spaces in empty line
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces the hard coded formatting options sent to language servers with those configured in user preferences.
What issues does this PR fix or reference?
Language Server formatting options are hardcoded #2728
Previous behavior
Documents are formatted with hardcoded "tab size" and "insert spaces" (if editor uses a language server, e.g. JSON editor)
New behavior
Documents are formatted with the "tab size" and "insert spaces" from the user preferences.
PR type
Signed-off-by: Kaloyan Raev [email protected]