Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Split launch.sh into two independent scripts #22408

Merged
merged 6 commits into from
Aug 1, 2023
Merged

chore: Split launch.sh into two independent scripts #22408

merged 6 commits into from
Aug 1, 2023

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jul 28, 2023

What does this PR do?

This PR splits launch.sh into two independent scripts:

  • provision-openshift-oauth-user.sh
  • start-happypath-tests.sh
    The main idea is to adapt HappyPath tests to run into disconnected environment.
    It will be possible into two steps:
  1. Run provision-openshift-oauth-user.sh against disconnected cluster
  2. Run start-happypath-tests.sh against microk8s cluster which have access to the internet

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

#21445

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Jul 28, 2023
@tolusha tolusha marked this pull request as draft July 28, 2023 14:22
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
@tolusha tolusha marked this pull request as ready for review July 31, 2023 13:21
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge

@tolusha tolusha merged commit bc4fc84 into main Aug 1, 2023
1 check passed
@tolusha tolusha deleted the 21445_2 branch August 1, 2023 06:31
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants