Adapt testsuites of the Language server validation and build features for DevWorkspaceHappyPath #20476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musienko-maxim
requested review from
Katka92,
nickboldt,
Ohrimenko1988,
rhopp and
ScrewTSW
as code owners
musienko-maxim
changed the title
che-bot
added
target/branch
|
✅ E2E Happy path tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
musienko-maxim
changed the title
musienko-maxim
force-pushed
the
CHE-20385
branch
from
1bafb1a to
f19fd5f
Compare
musienko-maxim
force-pushed
the
CHE-20385
branch
from
d364289 to
fd6b3ae
Compare
dmytro-ndp
reviewed
Sep 20, 2021
dmytro-ndp
reviewed
Sep 20, 2021
|
[crw-ci-test] |
|
✅ E2E Happy path tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
sleshchenko
reviewed
Sep 20, 2021
dmytro-ndp
approved these changes
Sep 20, 2021
|
❌ E2E Happy path tests failed ❗ See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
|
✅ E2E Happy path tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
sleshchenko
approved these changes
Sep 21, 2021
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We have the depended issue: #20385. We need to adapt the existed DevWorkspaceHappyPath test to this testflaw. Currently it adapts the DevWorkspaceHappyPath and Language server validation test cases
Screenshot/screencast of this PR
What issues does this PR fix or reference?
#20385.
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.