chore: Adapt Happy Path tests to the changes related to the Monaco upgrade #20204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…grade Signed-off-by: Roman Nikitenko <[email protected]>
che-bot
added
status/code-review
|
❌ E2E Happy path tests failed ❗ See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
9 tasks
RomanNikitenko
requested review from
Katka92,
musienko-maxim,
nickboldt,
Ohrimenko1988,
rhopp and
ScrewTSW
as code owners
|
@Katka92 , @ScrewTSW , @Ohrimenko1988 : FYI: PR Happy path tests are failing till eclipse-che/che-theia#1171 is merged. Happy path tests from this PR are passing in Che-theia PR with changes in editor, which Happy path tests are adapted to: eclipse-che/che-theia#1171 (comment) |
Ohrimenko1988
approved these changes
Jul 28, 2021
Katka92
approved these changes
Jul 28, 2021
thank you, Dmytro, I mentioned that in the PR description as well |
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR should be merged at the same time with eclipse-che/che-theia#1171
Signed-off-by: Roman Nikitenko [email protected]
What does this PR do?
The
Monacoversion was updated intheiarepo.The current PR provides some adaptation for
Happy Pathtests to get them working forche-theiaPRs.Screenshot/screencast of this PR
What issues does this PR fix or reference?
#20172
How to test this PR?
The
Happy Pathtests should pass successfully forche-theiaPRs.I have got the succeed tests for the corresponding PR of
che-theiaPR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.