Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitlab factory authentication using OAuth 2 flow #19521

Merged
merged 21 commits into from
Apr 27, 2021
Merged

Gitlab factory authentication using OAuth 2 flow #19521

merged 21 commits into from
Apr 27, 2021

Conversation

mshaposhnik
Copy link
Contributor

@mshaposhnik mshaposhnik commented Apr 7, 2021 •
edited
Loading

@mshaposhnik mshaposhnik requested a review from skabashnyuk April 7, 2021 12:14
@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Apr 7, 2021
@che-bot
Copy link
Contributor

che-bot commented Apr 9, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Apr 9, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

skabashnyuk
skabashnyuk reviewed Apr 12, 2021
View reviewed changes
Copy link
Contributor

@skabashnyuk skabashnyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good.

...-factory-gitlab/src/main/java/org/eclipse/che/api/factory/server/gitlab/GitlabApiClient.java Show resolved Hide resolved
...-gitlab/src/main/java/org/eclipse/che/api/factory/server/gitlab/GitlabOAuthTokenFetcher.java Show resolved Hide resolved
@che-bot
Copy link
Contributor

che-bot commented Apr 12, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Apr 14, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@mshaposhnik mshaposhnik changed the title Gitlab oauth Gitlab factory authentication using OAuth 2 flow Apr 14, 2021
@mshaposhnik mshaposhnik marked this pull request as ready for review April 14, 2021 14:50
@mshaposhnik mshaposhnik requested a review from nickboldt as a code owner April 14, 2021 14:50
@mshaposhnik mshaposhnik removed the request for review from nickboldt April 14, 2021 14:50
@che-bot che-bot added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Apr 15, 2021
@skabashnyuk skabashnyuk requested review from sparkoo and metlos April 16, 2021 06:31
metlos
metlos reviewed Apr 16, 2021
View reviewed changes
...-factory-gitlab/src/main/java/org/eclipse/che/api/factory/server/gitlab/GitlabApiClient.java
private final URI serverUrl;

private static final Duration DEFAULT_HTTP_TIMEOUT = ofSeconds(10);
private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure object mapper is thread safe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like yes

@che-bot
Copy link
Contributor

che-bot commented Apr 21, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Apr 22, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Apr 22, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Apr 26, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@mshaposhnik mshaposhnik merged commit 7035a9d into eclipse-che:master Apr 27, 2021
@che-bot che-bot added this to the 7.30 milestone Apr 27, 2021
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metlos metlos metlos left review comments

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@sparkoo sparkoo Awaiting requested review from sparkoo

@yhontyk yhontyk Awaiting requested review from yhontyk

@ibuziuk ibuziuk Awaiting requested review from ibuziuk

@MichalMaler MichalMaler Awaiting requested review from MichalMaler

@sleshchenko sleshchenko Awaiting requested review from sleshchenko

@themr0c themr0c Awaiting requested review from themr0c

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
7.30
Development

Successfully merging this pull request may close these issues.
4 participants
@mshaposhnik @che-bot @metlos @skabashnyuk