Bitbucket public repo factories support #18423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
che-bot
added
the
status/code-review
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
skabashnyuk
reviewed
Nov 23, 2020
assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties
Outdated
Show resolved
Hide resolved
...et-server/src/main/java/org/eclipse/che/api/factory/server/bitbucket/BitbucketURLParser.java
Outdated
Show resolved
Hide resolved
...itbucket-server/src/main/java/org/eclipse/che/api/factory/server/bitbucket/BitbucketUrl.java
Outdated
Show resolved
Hide resolved
...itbucket-server/src/main/java/org/eclipse/che/api/factory/server/bitbucket/BitbucketUrl.java
Outdated
Show resolved
Hide resolved
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
mshaposhnik
requested review from
ibuziuk,
nickboldt,
sleshchenko and
sparkoo
as code owners
mshaposhnik
requested review from
skabashnyuk and
metlos
and removed request for
nickboldt,
ibuziuk and
sleshchenko
metlos
reviewed
Nov 23, 2020
assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties
Outdated
Show resolved
Hide resolved
che-bot
added
the
kind/task
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
sparkoo
reviewed
Nov 23, 2020
...a/org/eclipse/che/api/factory/server/bitbucket/BitbucketServerFactoryParametersResolver.java
Outdated
Show resolved
Hide resolved
...et-server/src/main/java/org/eclipse/che/api/factory/server/bitbucket/BitbucketURLParser.java
Outdated
Show resolved
Hide resolved
...et-server/src/main/java/org/eclipse/che/api/factory/server/bitbucket/BitbucketURLParser.java
Outdated
Show resolved
Hide resolved
assembly/assembly-wsmaster-war/src/main/java/org/eclipse/che/api/deploy/WsMasterModule.java
Outdated
Show resolved
Hide resolved
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
skabashnyuk
approved these changes
Dec 2, 2020
sparkoo
reviewed
Dec 7, 2020
assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties
Outdated
Show resolved
Hide resolved
...et-server/src/main/java/org/eclipse/che/api/factory/server/bitbucket/BitbucketURLParser.java
Outdated
Show resolved
Hide resolved
...et-server/src/main/java/org/eclipse/che/api/factory/server/bitbucket/BitbucketURLParser.java
Outdated
Show resolved
Hide resolved
...et-server/src/main/java/org/eclipse/che/api/factory/server/bitbucket/BitbucketURLParser.java
Outdated
Show resolved
Hide resolved
…/che/che.properties Fix language Co-authored-by: Michal Vala <[email protected]>
sparkoo
approved these changes
Dec 7, 2020
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is the first step of customer request to process secure Bitbucket repository factories from on-prem installations. This will allow Bitbucket factories from public repos.
Example:
https://che-che-url.com/f?url=https://https://bitbucket.local.net/scm/project/repo.gitThis is NOT covering the Bitbucket SAAS, e.g. bitbucket.com.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
#18397
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.