Move to the quay.io #15569

vparfonov · 2019-12-24T09:23:55Z

Signed-off-by: Vitalii Parfonov [email protected]

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Docs PR

Signed-off-by: Vitalii Parfonov <[email protected]>

che-bot · 2019-12-24T09:42:55Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15569

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

dmytro-ndp · 2019-12-24T09:47:15Z

@vparfonov: FYI: Happy path E2E tests failed because MultiUser Eclipse Che had not properly deployed to minikube:
https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/Multiuser-Che-PR-check-E2E-Happy-path-tests-against-k8s/1501/artifact/logs-and-configs/che-logs/che-778888c64d-xvc4r.pod.log/*view*/

24-Dec-2019 09:40:18.588 INFO [jgroups-6,RemoteSubscriptionChannel,che-778888c64d-xvc4r-39719] org.apache.catalina.loader.WebappClassLoaderBase.checkStateForResourceLoading Illegal access: this web application instance has been stopped already. Could not load [org.jgroups.util.Headers]. The following stack trace is thrown for debugging purposes as well as to attempt to terminate the thread which caused the illegal access.
	java.lang.IllegalStateException: Illegal access: this web application instance has been stopped already. Could not load [org.jgroups.util.Headers]. The following stack trace is thrown for debugging purposes as well as to attempt to terminate the thread which caused the illegal access.
		at org.apache.catalina.loader.WebappClassLoaderBase.checkStateForResourceLoading(WebappClassLoaderBase.java:1380)
		at org.apache.catalina.loader.WebappClassLoaderBase.checkStateForClassLoading(WebappClassLoaderBase.java:1368)
		at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1220)
		at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1182)
		at org.jgroups.Message.putHeader(Message.java:466)
		at org.jgroups.protocols.pbcast.STABLE.sendStableMessage(STABLE.java:667)
		at org.jgroups.protocols.pbcast.STABLE$StableTask.run(STABLE.java:832)
		at org.jgroups.util.TimeScheduler3$Task.run(TimeScheduler3.java:328)
		at org.jgroups.util.TimeScheduler3$RecurringTask.run(TimeScheduler3.java:362)
		at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
		at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
		at java.lang.Thread.run(Thread.java:748)
24-Dec-2019 09:40:18.589 INFO [jgroups-6,RemoteSubscriptionChannel,che-778888c64d-xvc4r-39719] org.apache.catalina.loader.WebappClassLoaderBase.checkStateForResourceLoading Illegal access: this web application instance has been stopped already. Could not load [ch.qos.logback.core.status.WarnStatus]. The following stack trace is thrown for debugging purposes as well as to attempt to terminate the thread which caused the illegal access.
	java.lang.IllegalStateException: Illegal access: this web application instance has been stopped already. Could not load [ch.qos.logback.core.status.WarnStatus]. The following stack trace is thrown for debugging purposes as well as to attempt to terminate the thread which caused the illegal access.
		at org.apache.catalina.loader.WebappClassLoaderBase.checkStateForResourceLoading(WebappClassLoaderBase.java:1380)
		at org.apache.catalina.loader.WebappClassLoaderBase.checkStateForClassLoading(WebappClassLoaderBase.java:1368)
		at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1220)
		at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1182)
		at ch.qos.logback.classic.LoggerContext.noAppenderDefinedWarning(LoggerContext.java:186)
		at ch.qos.logback.classic.Logger.callAppenders(Logger.java:264)
		at ch.qos.logback.classic.Logger.buildLoggingEventAndAppend(Logger.java:421)
		at ch.qos.logback.classic.Logger.filterAndLog_0_Or3Plus(Logger.java:383)
		at ch.qos.logback.classic.Logger.error(Logger.java:538)
		at org.jgroups.logging.Slf4jLogImpl.error(Slf4jLogImpl.java:104)
		at org.jgroups.util.TimeScheduler3$Task.run(TimeScheduler3.java:331)
		at org.jgroups.util.TimeScheduler3$RecurringTask.run(TimeScheduler3.java:362)
		at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
		at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
		at java.lang.Thread.run(Thread.java:748)

There is maxura/che-server:15569 image which could be checked locally.

che-bot · 2019-12-24T10:00:38Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:15569
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

sleshchenko

🎉

Is there any plan to update values in chectl as well? For example: https://github.com/che-incubator/chectl/blob/5eb787953dd4eb67259ee141d147b99632799315/src/constants.ts
https://github.com/che-incubator/chectl/blob/72a098dbee61ec571d93306317c19da4de912770/make-release.sh

vparfonov · 2019-12-26T15:36:39Z

🎉

Is there any plan to update values in chectl as well? For example: https://github.com/che-incubator/chectl/blob/5eb787953dd4eb67259ee141d147b99632799315/src/constants.ts
https://github.com/che-incubator/chectl/blob/72a098dbee61ec571d93306317c19da4de912770/make-release.sh

I will create PR

skabashnyuk · 2019-12-26T16:11:33Z

assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties

@@ -545,12 +545,12 @@ che.factory.default_plugins=eclipse/che-machine-exec-plugin/nightly
 # Default Editor that should be provisioned into Devfile if there is no specified Editor
 # Format is `editorPublisher/editorName/editorVersion` value.
 # `NULL` or absence of value means that default editor should not be provisioned.
-che.workspace.devfile.default_editor=eclipse/che-theia/next
+che.workspace.devfile.default_editor=quay.io/eclipse/che-theia/next


Not sure about this change. This is id of an editor, not the image id.

you're totally right.
Images are defined in Plugin Registry and it's already changed to quay.io in eclipse-che/che-plugin-registry#323

skabashnyuk · 2019-12-26T16:11:46Z

assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties


 # Default Plugins which should be provisioned for Default Editor.
 # All the plugins from this list that are not explicitly mentioned in the user-defined devfile
 # will be provisioned but only when the default editor is used or if the user-defined editor is
 # the same as the default one (even if in different version).
 # Format is comma-separated `pluginPublisher/pluginName/pluginVersion` values, for example
 # eclipse/che-theia-exec-plugin/0.0.1,eclipse/che-theia-terminal-plugin/0.0.1
-che.workspace.devfile.default_editor.plugins=eclipse/che-machine-exec-plugin/nightly
+che.workspace.devfile.default_editor.plugins=quay.io/eclipse/che-machine-exec-plugin/nightly


same as editor

skabashnyuk · 2019-12-26T16:14:02Z

Do you plan to update images in https://github.com/eclipse/che-plugin-registry/tree/master/v3/plugins?

Up to you to decide when to merge

Signed-off-by: Vitalii Parfonov <[email protected]>

* Move to the quay.io: change image id to use quay.io Signed-off-by: Vitalii Parfonov <[email protected]>

vparfonov added 2 commits December 23, 2019 18:11

Move to the quay.io

b488353

Signed-off-by: Vitalii Parfonov <[email protected]>

chnang image id to use quay.io

a7aaae4

Signed-off-by: Vitalii Parfonov <[email protected]>

vparfonov requested review from ashumilova, benoitf, ibuziuk, l0rd, metlos, mshaposhnik, nickboldt, rhopp and sleshchenko as code owners December 24, 2019 09:23

che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 24, 2019

ibuziuk approved these changes Dec 24, 2019

View reviewed changes

sleshchenko approved these changes Dec 24, 2019

View reviewed changes

skabashnyuk previously requested changes Dec 26, 2019

View reviewed changes

gazarenkov mentioned this pull request Jan 9, 2020

Move CI infrastructure to CentOS CI #15571

Closed

10 tasks

Fix PR comments

c1080a2

Signed-off-by: Vitalii Parfonov <[email protected]>

vparfonov merged commit c07e261 into master Jan 11, 2020

vparfonov deleted the move2quay branch January 11, 2020 14:11

skabashnyuk pushed a commit to skabashnyuk/che that referenced this pull request Mar 11, 2020

Move to the quay.io (eclipse-che#15569)

cfa81f0

* Move to the quay.io: change image id to use quay.io Signed-off-by: Vitalii Parfonov <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move to the quay.io #15569

Move to the quay.io #15569

vparfonov commented Dec 24, 2019

che-bot commented Dec 24, 2019

dmytro-ndp commented Dec 24, 2019 •

edited

Loading

che-bot commented Dec 24, 2019

sleshchenko left a comment

vparfonov commented Dec 26, 2019 •

edited

Loading

skabashnyuk Dec 26, 2019

sleshchenko Dec 26, 2019

skabashnyuk Dec 26, 2019

skabashnyuk commented Dec 26, 2019

Move to the quay.io #15569

Move to the quay.io #15569

Conversation

vparfonov commented Dec 24, 2019

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Docs PR

che-bot commented Dec 24, 2019

dmytro-ndp commented Dec 24, 2019 • edited Loading

che-bot commented Dec 24, 2019

sleshchenko left a comment

Choose a reason for hiding this comment

vparfonov commented Dec 26, 2019 • edited Loading

skabashnyuk Dec 26, 2019

Choose a reason for hiding this comment

sleshchenko Dec 26, 2019

Choose a reason for hiding this comment

skabashnyuk Dec 26, 2019

Choose a reason for hiding this comment

skabashnyuk commented Dec 26, 2019

dmytro-ndp commented Dec 24, 2019 •

edited

Loading

vparfonov commented Dec 26, 2019 •

edited

Loading