Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UD] Add ability to create a new workspace from the dashboard with a devfile #15143

Merged
merged 8 commits into from
Nov 13, 2019
Merged

[UD] Add ability to create a new workspace from the dashboard with a devfile #15143

merged 8 commits into from
Nov 13, 2019

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This PR adds ability to create a new workspace from User Dashboard with a devfile.

DEMO

new-workspace-from-devfile

What issues does this PR fix or reference?

closes #13591

@akurinnoy
Remove unused directives.
5cbc47b 
Signed-off-by: Oleksii Kurinnyi <[email protected]>
@akurinnoy
Add ready-to-go-stacks directive.
94d09d7 
Signed-off-by: Oleksii Kurinnyi <[email protected]>
@akurinnoy
Add import-custom-stack directive.
4e1ddeb 
Signed-off-by: Oleksii Kurinnyi <[email protected]>
@akurinnoy
Adapt workspace creating flow in order to use ready-to-go-stacks an…
378ff1c 
…d `import-custom-stack`

Signed-off-by: Oleksii Kurinnyi <[email protected]>
@akurinnoy akurinnoy added the kind/enhancement A feature request - must adhere to the feature request template. label Nov 7, 2019
@akurinnoy akurinnoy requested review from benoitf and olexii4 November 7, 2019 13:42
@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 7, 2019
@che-bot
Copy link
Contributor

che-bot commented Nov 7, 2019

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Nov 7, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@akurinnoy
fix license headers
141b046 
Signed-off-by: Oleksii Kurinnyi <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Nov 7, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@akurinnoy
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Nov 7, 2019

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Nov 7, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@akurinnoy
Fix selenium test
00a23cf 
Signed-off-by: Oleksii Kurinnyi <[email protected]>
@akurinnoy
Fix compilation warnings
30daa04 
Signed-off-by: Oleksii Kurinnyi <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Nov 8, 2019

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Nov 8, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@akurinnoy
fix workspace name applying
7a14c42 
Signed-off-by: Oleksii Kurinnyi <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Nov 11, 2019

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@che-bot
Copy link
Contributor

che-bot commented Nov 11, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@sparkoo
Copy link
Member

sparkoo commented Nov 11, 2019

@akurinnoy There is an issue with editing devfile name/generateName caused by frontend validation #14695. Are your changes doing some frontend validation of workspace name or touching existing validation? Or it just sends the devfile to the server without any further validation?

@akurinnoy
Copy link
Contributor Author

@sparkoo thank you for pointing that issue out, we are going to take it for next sprint.
This PR doesn't change existing validation of workspace name.

@sparkoo sparkoo mentioned this pull request Nov 11, 2019
Closed
1 task
@SkorikSergey
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/2970//Selenium_20tests_20report/) doesn't show any regression against this Pull request.

benoitf
benoitf approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@akurinnoy akurinnoy merged commit ee55847 into master Nov 13, 2019
@akurinnoy akurinnoy deleted the CHE-13591 branch November 13, 2019 13:22
@che-bot che-bot added this to the 7.5.0 milestone Nov 13, 2019
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 13, 2019
@amisevsk amisevsk mentioned this pull request Dec 3, 2019
Closed
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
@akurinnoy
[UD] Add ability to create a new workspace from the dashboard with a …
29c2de3 
…devfile (#15143)

* Remove unused directives.

Signed-off-by: Oleksii Kurinnyi <[email protected]>

* Add `ready-to-go-stacks` directive.

Signed-off-by: Oleksii Kurinnyi <[email protected]>

* Add `import-custom-stack` directive.

Signed-off-by: Oleksii Kurinnyi <[email protected]>

* Adapt workspace creating flow in order to use `ready-to-go-stacks` and `import-custom-stack`

Signed-off-by: Oleksii Kurinnyi <[email protected]>

* fix license headers

Signed-off-by: Oleksii Kurinnyi <[email protected]>

* Fix selenium test

Signed-off-by: Oleksii Kurinnyi <[email protected]>

* Fix compilation warnings

Signed-off-by: Oleksii Kurinnyi <[email protected]>

* fix workspace name applying

Signed-off-by: Oleksii Kurinnyi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkorikSergey SkorikSergey SkorikSergey approved these changes

@benoitf benoitf benoitf approved these changes

@olexii4 olexii4 Awaiting requested review from olexii4

@ashumilova ashumilova Awaiting requested review from ashumilova

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

@dmytro-ndp dmytro-ndp Awaiting requested review from dmytro-ndp

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@Ohrimenko1988 Ohrimenko1988 Awaiting requested review from Ohrimenko1988

Assignees

@olexii4 olexii4

@akurinnoy akurinnoy

Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.

Add ability to create a new workspace from the dashboard with a devfile
6 participants
@akurinnoy @che-bot @sparkoo @SkorikSergey @benoitf @olexii4