Fix selenium tests in projectexplorer package #10452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoliy Bazko <[email protected]>
benoitf
added
target/branch
svor
approved these changes
Jul 17, 2018
tsmaeder
reviewed
Jul 18, 2018
| @@ -650,6 +650,11 @@ public void apply(java.util.Optional<VirtualFile> optionalFile) | |||
| callback.onSuccess(null); | |||
| } | |||
| } | |||
| }) | |||
| .catchError( | |||
| error -> { | |||
There was a problem hiding this comment.
Shouldn't we log this or show a message to the user?
There was a problem hiding this comment.
I don't think so.
Accordingly to the code above
} else {
removeFromOpeningFilesList(path, editorPartStack);
callback.onSuccess(null);
}
it is an usual case.
| .toString(); | ||
| .stream() | ||
| // target directory appears asynchronously and leads to failed tests | ||
| .filter(s -> !s.contains("target")) |
There was a problem hiding this comment.
shouldn't this be "startsWith("/target") for more robustness?
| @@ -86,6 +77,6 @@ private void openFileFromExternalLibraryAndCheckDisplayedText() { | |||
|
|
|||
| editor.waitActive(); | |||
| editor.waitTabIsPresent(CHECKING_FILE_NAME); | |||
| editor.waitTextIntoEditor(EXPECTED_EDITOR_TEXT); | |||
| assertTrue(editor.getVisibleTextFromEditor().contains("package javax.servlet")); | |||
There was a problem hiding this comment.
This tests for less text than before. Why not check the whole text?
There was a problem hiding this comment.
waitTextIntoEditor checks only visible text. So, it depends on the screen resolution.
In master branch it contains decomplied code which fits the screen. In 5730 branch it contains source code, that's why I've changed the expectation.
Signed-off-by: Anatoliy Bazko <[email protected]>
tsmaeder
approved these changes
Jul 18, 2018
benoitf
removed
the
status/code-review
tsmaeder
pushed a commit
that referenced
this pull request
Jul 27, 2018
* Fix selenium tests in projectexplorer package Signed-off-by: Anatoliy Bazko <[email protected]> * Fixup Signed-off-by: Anatoliy Bazko <[email protected]>
tolusha
added a commit
that referenced
this pull request
Aug 7, 2018
* Fix selenium tests in projectexplorer package Signed-off-by: Anatoliy Bazko <[email protected]> * Fixup Signed-off-by: Anatoliy Bazko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Aug 22, 2018
* Fix selenium tests in projectexplorer package Signed-off-by: Anatoliy Bazko <[email protected]> * Fixup Signed-off-by: Anatoliy Bazko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Aug 29, 2018
* Fix selenium tests in projectexplorer package Signed-off-by: Anatoliy Bazko <[email protected]> * Fixup Signed-off-by: Anatoliy Bazko <[email protected]>
tolusha
added a commit
that referenced
this pull request
Sep 5, 2018
* Fix selenium tests in projectexplorer package Signed-off-by: Anatoliy Bazko <[email protected]> * Fixup Signed-off-by: Anatoliy Bazko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Sep 13, 2018
* Fix selenium tests in projectexplorer package Signed-off-by: Anatoliy Bazko <[email protected]> * Fixup Signed-off-by: Anatoliy Bazko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Sep 20, 2018
* Fix selenium tests in projectexplorer package Signed-off-by: Anatoliy Bazko <[email protected]> * Fixup Signed-off-by: Anatoliy Bazko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Sep 26, 2018
* Fix selenium tests in projectexplorer package Signed-off-by: Anatoliy Bazko <[email protected]> * Fixup Signed-off-by: Anatoliy Bazko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 1, 2018
* Fix selenium tests in projectexplorer package Signed-off-by: Anatoliy Bazko <[email protected]> * Fixup Signed-off-by: Anatoliy Bazko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 5, 2018
* Fix selenium tests in projectexplorer package Signed-off-by: Anatoliy Bazko <[email protected]> * Fixup Signed-off-by: Anatoliy Bazko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 12, 2018
* Fix selenium tests in projectexplorer package Signed-off-by: Anatoliy Bazko <[email protected]> * Fixup Signed-off-by: Anatoliy Bazko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 16, 2018
* Fix selenium tests in projectexplorer package Signed-off-by: Anatoliy Bazko <[email protected]> * Fixup Signed-off-by: Anatoliy Bazko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
* Fix selenium tests in projectexplorer package Signed-off-by: Anatoliy Bazko <[email protected]> * Fixup Signed-off-by: Anatoliy Bazko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Anatoliy Bazko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Anatoliy Bazko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Anatoliy Bazko <[email protected]>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
Signed-off-by: Anatoliy Bazko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatoliy Bazko [email protected]
What does this PR do?
Fix tests in projectexplorer package
What issues does this PR fix or reference?
#10451