Update DTD for GWT-module descriptors #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vparfonov
pushed a commit
that referenced
this pull request
Apr 16, 2015
Update DTD for GWT-module descriptors
evidolob
pushed a commit
that referenced
this pull request
Apr 5, 2016
CHE-370: add loader widget for the process of resolving dependencies
benoitf
added a commit
that referenced
this pull request
May 27, 2016
…ove InstanceKey #1 new docker recipe type currently we have type:"dockerfile", location: "http://path-to-recipe" now we could provide type:"dockerfile", content: "FROM codenvy/foo\nENV FLORENT=TRUE\" and type:"image", location or content: "codenvy/foo" #2 InstanceKey Up to now, InstanceKey was used to perform snapshot recovery. But machine source is a way to provide this information. So remove InstanceKey and replace it by MachineSource (and DockerMachineSource instead of DockerInstanceKey) InstanceProvider: void removeInstanceSnapshot(InstanceKey instanceKey) --> void removeInstanceSnapshot(MachineSource machineSource) Instance: InstanceKey saveToSnapshot(String owner) --> MachineSource saveToSnapshot(String owner) #3 InstanceProvider model To avoid also that MachineManager "knows" the inner type, the recipe handling is moved to the instance provider implementation And as the snapshot handling is with MachineSource (included in MachineConfig included in Machine), no need to give extra InstanceKey parameter Replace two previous methods Instance createInstance(Recipe recipe, Machine machine, LineConsumer creationLogsOutput) Instance createInstance(InstanceKey instanceKey, Machine machine, LineConsumer creationLogsOutput) throws NotFoundException, InvalidInstanceSnapshotException, MachineException; by only one: createInstance(Machine machine, LineConsumer creationLogsOutput) Change-Id: Ia7ea97bc1a44059b4892f5db387f54f2e1709fa3 Signed-off-by: Florent BENOIT <[email protected]>
ashumilova
pushed a commit
that referenced
this pull request
May 27, 2016
Added samples to CHE project, renamed groupId, artifactId Signed-off-by: Edgar Mueller <[email protected]>
benoitf
added a commit
that referenced
this pull request
May 29, 2016
…ove InstanceKey #1 new docker recipe type currently we have type:"dockerfile", location: "http://path-to-recipe" now we could provide type:"dockerfile", content: "FROM codenvy/foo\nENV FLORENT=TRUE\" and type:"image", location or content: "codenvy/foo" #2 InstanceKey Up to now, InstanceKey was used to perform snapshot recovery. But machine source is a way to provide this information. So remove InstanceKey and replace it by MachineSource (and DockerMachineSource instead of DockerInstanceKey) InstanceProvider: void removeInstanceSnapshot(InstanceKey instanceKey) --> void removeInstanceSnapshot(MachineSource machineSource) Instance: InstanceKey saveToSnapshot(String owner) --> MachineSource saveToSnapshot(String owner) #3 InstanceProvider model To avoid also that MachineManager "knows" the inner type, the recipe handling is moved to the instance provider implementation And as the snapshot handling is with MachineSource (included in MachineConfig included in Machine), no need to give extra InstanceKey parameter Replace two previous methods Instance createInstance(Recipe recipe, Machine machine, LineConsumer creationLogsOutput) Instance createInstance(InstanceKey instanceKey, Machine machine, LineConsumer creationLogsOutput) throws NotFoundException, InvalidInstanceSnapshotException, MachineException; by only one: createInstance(Machine machine, LineConsumer creationLogsOutput) Change-Id: Ia7ea97bc1a44059b4892f5db387f54f2e1709fa3 Signed-off-by: Florent BENOIT <[email protected]>
benoitf
added a commit
that referenced
this pull request
May 30, 2016
…ove InstanceKey #1 new docker recipe type currently we have type:"dockerfile", location: "http://path-to-recipe" now we could provide type:"dockerfile", content: "FROM codenvy/foo\nENV FLORENT=TRUE\" and type:"image", location or content: "codenvy/foo" #2 InstanceKey Up to now, InstanceKey was used to perform snapshot recovery. But machine source is a way to provide this information. So remove InstanceKey and replace it by MachineSource (and DockerMachineSource instead of DockerInstanceKey) InstanceProvider: void removeInstanceSnapshot(InstanceKey instanceKey) --> void removeInstanceSnapshot(MachineSource machineSource) Instance: InstanceKey saveToSnapshot(String owner) --> MachineSource saveToSnapshot(String owner) #3 InstanceProvider model To avoid also that MachineManager "knows" the inner type, the recipe handling is moved to the instance provider implementation And as the snapshot handling is with MachineSource (included in MachineConfig included in Machine), no need to give extra InstanceKey parameter Replace two previous methods Instance createInstance(Recipe recipe, Machine machine, LineConsumer creationLogsOutput) Instance createInstance(InstanceKey instanceKey, Machine machine, LineConsumer creationLogsOutput) throws NotFoundException, InvalidInstanceSnapshotException, MachineException; by only one: createInstance(Machine machine, LineConsumer creationLogsOutput) Change-Id: Ia7ea97bc1a44059b4892f5db387f54f2e1709fa3 Signed-off-by: Florent BENOIT <[email protected]>
benoitf
added a commit
that referenced
this pull request
May 30, 2016
…ove InstanceKey #1 new docker recipe type currently we have type:"dockerfile", location: "http://path-to-recipe" now we could provide type:"dockerfile", content: "FROM codenvy/foo\nENV FLORENT=TRUE\" and type:"image", location or content: "codenvy/foo" #2 InstanceKey Up to now, InstanceKey was used to perform snapshot recovery. But machine source is a way to provide this information. So remove InstanceKey and replace it by MachineSource (and DockerMachineSource instead of DockerInstanceKey) InstanceProvider: void removeInstanceSnapshot(InstanceKey instanceKey) --> void removeInstanceSnapshot(MachineSource machineSource) Instance: InstanceKey saveToSnapshot(String owner) --> MachineSource saveToSnapshot(String owner) #3 InstanceProvider model To avoid also that MachineManager "knows" the inner type, the recipe handling is moved to the instance provider implementation And as the snapshot handling is with MachineSource (included in MachineConfig included in Machine), no need to give extra InstanceKey parameter Replace two previous methods Instance createInstance(Recipe recipe, Machine machine, LineConsumer creationLogsOutput) Instance createInstance(InstanceKey instanceKey, Machine machine, LineConsumer creationLogsOutput) throws NotFoundException, InvalidInstanceSnapshotException, MachineException; by only one: createInstance(Machine machine, LineConsumer creationLogsOutput) Change-Id: Ia7ea97bc1a44059b4892f5db387f54f2e1709fa3 Signed-off-by: Florent BENOIT <[email protected]>
benoitf
added a commit
that referenced
this pull request
May 30, 2016
…ove InstanceKey #1 new docker recipe type currently we have type:"dockerfile", location: "http://path-to-recipe" now we could provide type:"dockerfile", content: "FROM codenvy/foo\nENV FLORENT=TRUE\" and type:"image", location or content: "codenvy/foo" #2 InstanceKey Up to now, InstanceKey was used to perform snapshot recovery. But machine source is a way to provide this information. So remove InstanceKey and replace it by MachineSource (and DockerMachineSource instead of DockerInstanceKey) InstanceProvider: void removeInstanceSnapshot(InstanceKey instanceKey) --> void removeInstanceSnapshot(MachineSource machineSource) Instance: InstanceKey saveToSnapshot(String owner) --> MachineSource saveToSnapshot(String owner) #3 InstanceProvider model To avoid also that MachineManager "knows" the inner type, the recipe handling is moved to the instance provider implementation And as the snapshot handling is with MachineSource (included in MachineConfig included in Machine), no need to give extra InstanceKey parameter Replace two previous methods Instance createInstance(Recipe recipe, Machine machine, LineConsumer creationLogsOutput) Instance createInstance(InstanceKey instanceKey, Machine machine, LineConsumer creationLogsOutput) throws NotFoundException, InvalidInstanceSnapshotException, MachineException; by only one: createInstance(Machine machine, LineConsumer creationLogsOutput) Change-Id: Ia7ea97bc1a44059b4892f5db387f54f2e1709fa3 Signed-off-by: Florent BENOIT <[email protected]>
ghost
mentioned this pull request
ghost
mentioned this pull request
1 task
Closed
ghost
mentioned this pull request
johnmcollier
pushed a commit
to johnmcollier/che
that referenced
this pull request
Jun 20, 2019
Move meta.yamls to proper directory
This was referenced Jun 21, 2019
4 tasks
3 tasks
tomgeorge
pushed a commit
that referenced
this pull request
Apr 21, 2020
che #15906 Adding 'che.workspace.stop.role.enabled' property in order to have a possibility to disable the 'OpenShiftStopWorkspaceRoleProvisioner'
4 tasks
3 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.