-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oAuth-proxy enhancements for Azure AKS deployment #21450
Comments
@karatkep thank you for this issue and the related contribution. Those enhancements were needed to deploy to AKS? And using the instructions in your repo are ment to be used by anyone trying to deploy to AKS? I am asking because we are considering to:
|
Hi Mario,
It's correct, the proposed enhancements were needed to deploy Che to Azure
AKS. My instructions will be slightly updated because we found a more
elegant way to solve reported issue during code review. Thanks to @tolusha
and @sparkoo for the help.
And of course I will be glad to write a blog post and explain what issue we
met and how it has been resolved in the new version of Che.
Best Regards,
Piotr (aka karatkep)
…On Thu, Jun 23, 2022 at 12:18 PM Mario Loriedo ***@***.***> wrote:
@karatkep <https://github.com/karatkep> thank you for this issue and the
related contribution. Those enhancements were needed to deploy to AKS? And
using the instructions in your repo
<https://github.com/karatkep/che-aks-installer> are ment to be used by
anyone trying to deploy to AKS?
I am asking because we are considering to:
1. make this PR as a new and notworkthy addition to include in next
release notes
2. proposing you to contribute a blog post that explains how to deploy
Che to AKS
—
Reply to this email directly, view it on GitHub
<#21450 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/APGFNMECKJTQMPXWLEMCB63VQQTU3ANCNFSM5YG2FNCA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@karatkep I have added this issue in v7.50 release notes. If you have some instructions on how to deploy Che on Azure AKS please share so that we can make a blog post out of it. You may also submit a PR yourself on our blog github repository if you can, but that's not required. |
@l0rd Please review eclipse-che/blog#29 |
Faster than the wind 👍 Will review that later today. |
RN: upstream only |
sync'd to Red Hat JIRA https://issues.redhat.com/browse/CRW-3845 |
Is your enhancement related to a problem? Please describe
There are several enhancements of ouath-proxy configuration (aka oauth-proxy.cfg) for kubernetes:
pass_access_token
totrue
(default value isfalse
) to pass access token to upstream via "X-Forwarded-Access-Token"cookie_refresh
to1h0m0s
to refresh the cookie when duration has elapsed after cookie was initially set.whitelist_domains
to whitelist che domain (ie: .yourcompany.com)cookie_domains
to set cookie domain to force cookies to (ie: .yourcompany.com)OAuthScope
to Che Resource to allow users to configure Access Token Scope.Describe the solution you'd like
Update che-operator to support addition configuration of ouath-proxy for kubernetes
Describe alternatives you've considered
No response
Release Notes Text
Enhancements needed to deploy Che on Azure AKS, contributed by @karatkep. Thank you for your contribution!
The text was updated successfully, but these errors were encountered: