Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display devfile v2 getting started in dashboard if DevWorkspace is enabled #19923

Closed
benoitf opened this issue Jun 3, 2021 · 0 comments · Fixed by eclipse-che/che-dashboard#262
Closed

Display devfile v2 getting started in dashboard if DevWorkspace is enabled #19923

benoitf opened this issue Jun 3, 2021 · 0 comments · Fixed by eclipse-che/che-dashboard#262
Assignees
@benoitf
Labels
area/dashboard engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@benoitf
Copy link
Contributor

benoitf commented Jun 3, 2021

Is your enhancement related to a problem? Please describe.

For now Eclipse Che dashboard shows the list of Getting started.
These getting started are only devfile v1.
When turning on the toggle for DevWorkspace, dashboard should display instead the devfile v2 getting started

Describe the solution you'd like

Displays devfile v2 getting started if devWorkspace support is enabled

Describe alternatives you've considered

Allow to switch between v1/v2 but as v1 will disappear anyway and that v2 is opt-in feature, better to show only devfile v2.

Additional context

reminder: to enable dev workspaces:

spec:
  devWorkspace:
    enable: true
@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. area/dashboard labels Jun 3, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jun 3, 2021
@benoitf benoitf mentioned this issue Jun 3, 2021
Closed
5 tasks
benoitf added a commit to benoitf/che-dashboard that referenced this issue Jun 3, 2021
@benoitf
feat(devfile): Display devfile v2 getting started if some are availab…
267d859 
…le and if devWorkspace setting is enabled

Use the factory resolver to fetch the devfile content as the v2 links are repositories link (not direct devfile.yaml links stored in the devfile registry)

eclipse-che/che#19923
@benoitf benoitf mentioned this issue Jun 3, 2021
Closed
@dmytro-ndp dmytro-ndp added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jun 3, 2021
@dmytro-ndp dmytro-ndp added the engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. label Jun 3, 2021
benoitf added a commit to eclipse-che/che-dashboard that referenced this issue Jun 4, 2021
@benoitf
feat(devfile): Display devfile v2 getting started if some are availab…
610c6e9 
…le and if devWorkspace setting is enabled

Use the factory resolver to fetch the devfile content as the v2 links are repositories link (not direct devfile.yaml links stored in the devfile registry)

eclipse-che/che#19923
@benoitf benoitf mentioned this issue Jun 4, 2021
Merged
benoitf added a commit to eclipse-che/che-dashboard that referenced this issue Jun 8, 2021
@benoitf
feat(devfile): Display devfile v2 getting started if some are availab…
d3efbca 
…le and if devWorkspace setting is enabled

Use the factory resolver to fetch the devfile content as the v2 links are repositories link (not direct devfile.yaml links stored in the devfile registry)

eclipse-che/che#19923
@sleshchenko sleshchenko assigned benoitf and unassigned sleshchenko Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoitf benoitf

Labels
area/dashboard engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
4 participants
@benoitf @dmytro-ndp @sleshchenko @che-bot