Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language Server Protocol: Rename feature #1806

Closed
vparfonov opened this issue Jul 18, 2016 · 5 comments
Closed

Language Server Protocol: Rename feature #1806

vparfonov opened this issue Jul 18, 2016 · 5 comments
Assignees
@evidolob
Labels
kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.

Comments

@vparfonov
Copy link
Contributor

The rename request is sent from the client to the server to do a workspace wide rename of a symbol.
https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#rename
@vparfonov vparfonov added kind/enhancement A feature request - must adhere to the feature request template. team/ide labels Jul 18, 2016
@svenefftinge svenefftinge mentioned this issue Jul 18, 2016
Closed
26 tasks
@vparfonov vparfonov mentioned this issue Jul 27, 2016
Closed
@evidolob
Copy link
Contributor

The result of rename is list changes that we should apply to files over workspace, I'm not sure that client(browser) is right place to do that. We need to thick how apply that changes on server(ws-agent).

@gazarenkov gazarenkov mentioned this issue Aug 12, 2016
Closed
8 tasks
@tsmaeder
Copy link
Contributor

@evidolob From the spec, I can't say if the delta you get back is describing an edit that has happened on the back end or if it's a "todo" for the client. Do you have more info?

@tsmaeder
Copy link
Contributor

@evidolob I think you are correct. However, we do have an agent in the workspace that could execute the change. We don't really have to have the exact same protocol between the che ide and the language server api ws-agent and the individual language server implementations. Not sure where filed buffers live in che, though.

@tsmaeder
Copy link
Contributor

Note that implementing infrastructure for applying workspace edits would also benefit #3957

@evidolob
Copy link
Contributor

This issue depends on #5955 pull request

@evidolob evidolob added the status/in-progress This issue has been taken by an engineer and is under active development. label Sep 12, 2017
evidolob pushed a commit that referenced this issue Oct 6, 2017
#1806 add service and UI for rename feature
325cdf5 
Signed-off-by: Yevhen Vydolob <[email protected]>
evidolob pushed a commit that referenced this issue Oct 6, 2017
#1806 apply rename, show rename dialog if user press hotkey second time
3c817fc 
Signed-off-by: Yevhen Vydolob <[email protected]>
evidolob pushed a commit that referenced this issue Oct 6, 2017
#1806 fix formatting, dependencies
0da06f7 
Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob evidolob mentioned this issue Oct 6, 2017
Merged
@evidolob evidolob added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Oct 6, 2017
evidolob pushed a commit that referenced this issue Oct 9, 2017
#1806 remove commented code
8d27594 
Signed-off-by: Yevhen Vydolob <[email protected]>
evidolob added a commit that referenced this issue Oct 9, 2017
@evidolob
Language Server Protocol Rename implementation (#6615)
59abab9 
* #1806 add service and UI for rename feature
Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob evidolob closed this as completed Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evidolob evidolob

Labels
kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@evidolob @vparfonov @tsmaeder