Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Server Protocol: ShowMessage Request feature #1794

Closed
vparfonov opened this issue Jul 18, 2016 · 3 comments
Closed

Language Server Protocol: ShowMessage Request feature #1794

vparfonov opened this issue Jul 18, 2016 · 3 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@vparfonov
Copy link
Contributor

New: The show message request is sent from a server to a client to ask the client to display a particular message in the user interface. In addition to the show message notification the request allows to pass actions and to wait for an answer from the client.
https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#showmessage-request

@vparfonov vparfonov added kind/enhancement A feature request - must adhere to the feature request template. team/ide labels Jul 18, 2016
@slemeur
Copy link
Contributor

slemeur commented Nov 21, 2016

This issue has been discussed with @xcoulon who wanted to work on it.

After studying the specification https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#showmessage-request we think that there is some missing parts in order for the IDE to properly handle the MessageActionItem.

The specification is mentioning certain actions: retry, show logs. This list of actions is not exhaustive and not normalized (meaning, all LS implementation are supposely able to send different type of actions).

In order to move forward, we have studied existing LS (for JDT + sourcegraph), but we have not found any use of this.

For the time being - in order to start the implementation this issue needs:

  • more detailed specification
  • samples
  • actually be used in some LS

@slemeur
Copy link
Contributor

slemeur commented Nov 21, 2016

Linked to question: microsoft/language-server-protocol#130

@tsmaeder
Copy link
Contributor

tsmaeder commented Jan 4, 2017

I'm starting work on this.

@evidolob evidolob added the status/in-progress This issue has been taken by an engineer and is under active development. label Jul 14, 2017
evidolob pushed a commit that referenced this issue Jul 21, 2017
Signed-off-by: Yevhen Vydolob <[email protected]>
evidolob pushed a commit that referenced this issue Aug 1, 2017
Signed-off-by: Yevhen Vydolob <[email protected]>
evidolob pushed a commit that referenced this issue Aug 1, 2017
Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob evidolob added status/pending-merge and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Aug 2, 2017
evidolob pushed a commit that referenced this issue Aug 22, 2017
evidolob pushed a commit that referenced this issue Sep 4, 2017
Signed-off-by: Yevhen Vydolob <[email protected]>
evidolob added a commit that referenced this issue Sep 4, 2017
@evidolob evidolob closed this as completed Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

4 participants