Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes to local git config with user Che git config #13959

Closed
6 of 23 tasks
vinokurig opened this issue Jul 22, 2019 · 5 comments
Closed
6 of 23 tasks

Sync changes to local git config with user Che git config #13959

vinokurig opened this issue Jul 22, 2019 · 5 comments
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template.

Comments

@vinokurig
Copy link
Contributor

vinokurig commented Jul 22, 2019

Describe the bug

Git commit command requires committer name and email in the git config. Each time when the workspace restarts, git commit asks for committer name and email, even if it was set before restart.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Set Git committer name and email:
git config --global user.email "[email protected]"
git config --global user.name "Your Name"
  1. Perform git commit from terminal or from the SCM Tab => committed successfully.
  2. Restart workspace
  3. Perform git commit.
    WRONG Error occurs:
*** Please tell me who you are.

Run

  git config --global user.email "[email protected]"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident name (for <[email protected]>) not allowed

Expected behavior

Git commit should be successful, if the user data is set once.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context

@vinokurig vinokurig added area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. labels Jul 22, 2019
@l0rd l0rd added the status/duplicate Issue identified as a duplicate of another issue label Jul 22, 2019
@l0rd
Copy link
Contributor

l0rd commented Jul 22, 2019

@vinokurig this looks like a duplicate of #13874. Please re-open if you think that's not the case.

@vzhukovs
Copy link
Contributor

Reopen this issue, because it doesn't duplicate #13874. This issue needs to find the way to store ~/.gitconfig, when workspace restarts.

@vzhukovs vzhukovs reopened this Jul 29, 2019
@vzhukovs vzhukovs added this to the 7.1.0 milestone Jul 29, 2019
@vparfonov vparfonov modified the milestones: 7.1.0, 7.x Jul 29, 2019
@sunix sunix added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 30, 2019
@nickboldt nickboldt added status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jul 31, 2019
@nickboldt
Copy link
Contributor

I see this was added to 7.1 then moved to 7.x. Maybe we split the difference and set it to 7.2 or 7.3?

@benoitf benoitf removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 1, 2019
@benoitf benoitf modified the milestones: 7.x, 7.2.0 Aug 1, 2019
@l0rd l0rd changed the title Git config file is lost on workspace restart Sync changes to local git config with user Che git config Aug 2, 2019
@l0rd
Copy link
Contributor

l0rd commented Aug 2, 2019

@vzhukovskii what I understand is:

So #13874 is a pre-requisite of this issue and even a P1. While this issue for me is not a major issue and I would keep 7.x

@l0rd l0rd modified the milestones: 7.2.0, 7.x Aug 2, 2019
@vzhukovs
Copy link
Contributor

vzhukovs commented Aug 2, 2019

@l0rd yes, you're right, #13874 has higher priority.

@slemeur slemeur removed the status/duplicate Issue identified as a duplicate of another issue label Aug 2, 2019
@vzhukovs vzhukovs self-assigned this Aug 30, 2019
vzhukovs added a commit to eclipse-che/che-theia that referenced this issue Sep 13, 2019
Add ability to set up git user name and email in theia preferences
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

No branches or pull requests

8 participants