This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Rebind overwrite dialog by adding check for modification time bias #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladyslav Zhukovskyi <[email protected]>
vzhukovs
requested review from
azatsarynnyy,
benoitf and
RomanNikitenko
as code owners
|
✅ E2E Happy path tests succeed 🎉
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) |
azatsarynnyy
approved these changes
Sep 17, 2020
Signed-off-by: Vladyslav Zhukovskyi <[email protected]>
|
[ci-build] |
|
✅ E2E Happy path tests succeed 🎉
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) |
1 task
This was referenced Sep 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This changes proposal rebinds default file overwrite dialog by adding an additional check for modification time bias.
The problem which this changes proposal fixes described in followed comment.
Signed-off-by: Vladyslav Zhukovskyi [email protected]
What issues does this PR fix or reference?
eclipse-che/che#16751
Release Notes
N/A
Docs PR
N/A
Happy Path Channel
HAPPY_PATH_CHANNEL=stable