Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Make theia hostname configurable #626

Merged
merged 2 commits into from
Feb 14, 2020
Merged

Make theia hostname configurable #626

merged 2 commits into from
Feb 14, 2020

Conversation

metlos
Copy link
Contributor

@metlos metlos commented Feb 13, 2020 •
edited
Loading

What does this PR do?

This makes Theia listen on configurable hostname. This is taken advantage of in eclipse-che/che-plugin-registry#378 which makes the Theia endpoint listen on localhost only to enable truly secure deployment.

What issues does this PR fix or reference?

eclipse-che/che#15651, eclipse-che/che#15890, eclipse-che/che-plugin-registry#378

@benoitf
Copy link
Contributor

benoitf commented Feb 13, 2020

I think it'll break tests that are using directly the docker image (as there is no JWT/etc stuff)
so probably needs an env entry saying it needs to stick to 127.0.0.1 in that case

@che-bot
Copy link
Contributor

che-bot commented Feb 13, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:626
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:626

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@metlos
The hostname on which Theia starts is now configurable through
c32abb9 
THEIA_HOST env var with the default of 0.0.0.0 to preserve the original
behavior.
benoitf
benoitf approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@benoitf benoitf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should update title of PR (and do not forget to squash commits)

@metlos metlos changed the title Make theia listen only on localhost Make theia hostname configurable Feb 13, 2020
@metlos metlos mentioned this pull request Feb 13, 2020
Merged
@che-bot
Copy link
Contributor

che-bot commented Feb 13, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:626
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:626

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@metlos
Copy link
Contributor Author

metlos commented Feb 14, 2020

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Feb 14, 2020

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:626
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:626

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@metlos metlos merged commit ae27d4a into eclipse-che:master Feb 14, 2020
@metlos metlos mentioned this pull request Feb 15, 2020
Closed
vinokurig pushed a commit that referenced this pull request Apr 6, 2021
@ericwill
Upgrade vscode-intelephense-client to 1.5.4 (#626)
4dce2bd 
* Deprecate old PHP plugins
* Move plugin to proper folder structure (publisher/extension-name)

Signed-off-by: Eric Williams <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RomanNikitenko RomanNikitenko RomanNikitenko approved these changes

@vzhukovs vzhukovs vzhukovs approved these changes

@benoitf benoitf benoitf approved these changes

@azatsarynnyy azatsarynnyy Awaiting requested review from azatsarynnyy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@metlos @benoitf @che-bot @vzhukovs @RomanNikitenko