This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Rename factory plugin to workspace plugin #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaliy-guliy
requested review from
benoitf,
sunix,
evidolob,
olexii4,
vinokurig,
mmorhun and
akurinnoy
akurinnoy
approved these changes
Jan 2, 2020
vinokurig
approved these changes
Jan 3, 2020
olexii4
approved these changes
Jan 3, 2020
|
crw-ci-test |
|
Can this change break any devfiles? |
|
@gorkem I would say no as it's more 'internal renaming', it's not exposed in devfiles |
|
crw-ci-test |
|
@vitaliy-guliy can you rebase code (to fix ci-build check ?) |
Signed-off-by: Vitaliy Gulyy <[email protected]>
vitaliy-guliy
force-pushed
the
rename-factory-plugin
branch
from
ae680a6 to
67725ae
Compare
|
@benoitf done |
|
thx |
|
crw-ci-test |
2 similar comments
|
crw-ci-test |
|
crw-ci-test |
|
The test failure is now expected. @rhopp is working on a solution right now (issue: eclipse-che/che#15586). |
|
@RomanNikitenko @artaleks9 thanks! |
vinokurig
pushed a commit
that referenced
this pull request
Apr 6, 2021
Signed-off-by: Mykhailo Kuznietsov <[email protected]> Co-authored-by: Mykhailo Kuznietsov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Renames the factory plugin to workspace plugin.
What issues does this PR fix or reference?
eclipse-che/che#14653