-
Notifications
You must be signed in to change notification settings - Fork 111
Use component for task configuration instead of container name #512
Conversation
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
9341d4f
to
1c6b3eb
Compare
Signed-off-by: Roman Nikitenko <[email protected]>
1c6b3eb
to
4dd57d5
Compare
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
crw-ci-test |
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
crw-ci-test |
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it on minikube according to the proposed scenario. Works as advertised ) 👍
Backward compatibility is handled very well.
Note for anyone who wants to test it: 8 Gb is insufficient for running minikube to test the PR with the proposed DevFile. I successfully run it with 16 Gb. |
What does this PR do?
Use
component
field for task configuration instead ofcontainerName
one.containerName
is used to indicate which container should be used for running task configuration.The problem is: some container names are dynamic and are changed at restarting workspace.
The PR changes suggest to use
component
instead ofcontainerName
for this goal. So, the new behavior is:devfile
andtasks.json
files keepcomponent
fieldcomponent
is used to identify the target container at running a configurationBackward compatibility for
containerName
field of task configuration is provided for existing workspaces.So, the following configuration:
at starting workspace is replaced by:
Note:
containerName
is replaced by emptycomponent
field if the corresponding component is not found (dynamic container name case). List of containers is displayed at running task for this case and user has opportunity to select a container for running.What issues does this PR fix or reference?
eclipse-che/che#13993
How to test
docker image: maxura/che-theia:512
related to the current PR.Devfile
Check that
tasks.json
file containsche
task configurations withcomponent
field instead ofcontainerName
filed.Try to run tasks, try to stop workspace, start workspace and run tasks again: components
theia-editor
andtsc
have dynamic names for containers, so pay attention on runningtest theia component
andtest tsc component
tasks after restarting workspace.Component
go-k8s
hasgo-110-server
andgo-112-server
containers, so at running oftest k8s component
task dropdown list should display only these containers instead of all containers.You can check backward compatibility for
containerName
field of task configuration:test che-dev component
replacecomponent
field bycontainerName
intasks.json
file and refresh the page. Expected behavior -containerName
is replaced bycomponent
field and task can be run.containerName
is replaced bycomponent
field with empty value, at running the task dopdown list is displayed and user has opportunity to select a container for running.Signed-off-by: Roman Nikitenko [email protected]