Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Change way of storage runtime info for che tasks #419

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

RomanNikitenko
Copy link
Member

@RomanNikitenko RomanNikitenko commented Aug 29, 2019

What does this PR do?

Improves the way of storage runtime info for Che tasks.

We keep runtime info for Che tasks on plugin side. The problem is the plugin side is reloaded each time the browser refreshes and we lose runtime info at this step. For more details please see eclipse-che/che#13722 (comment).

The changes suggest to store runtime info on node side of eclipse-che/theia-plugin-ext.

What issues does this PR fix or reference?

eclipse-che/che#13722

How to test

The changes are related to che tasks, so please try to run any che task from My Workspace panel and from Terminal -> Run Task menu as well

Signed-off-by: Roman Nikitenko [email protected]

@che-bot
Copy link
Contributor

che-bot commented Sep 27, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Sep 27, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@che-bot
Copy link
Contributor

che-bot commented Oct 2, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@che-bot
Copy link
Contributor

che-bot commented Oct 7, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Oct 7, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@eclipse-che eclipse-che deleted a comment from che-bot Oct 7, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Oct 7, 2019
@che-bot
Copy link
Contributor

che-bot commented Oct 7, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Oct 8, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Oct 8, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@RomanNikitenko
Copy link
Member Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Oct 9, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • logs and configs
  • "che-theia" docker image: maxura/che-theia:419
  • "che-theia-endpoint-runtime" docker image: maxura/che-theia-endpoint-runtime:419
  • "che-remote-plugin-runner-java8" docker image: maxura/che-remote-plugin-runner-java8:419
  • "che-remote-plugin-kubernetes-tooling-1.0.0" docker image: maxura/che-remote-plugin-kubernetes-tooling-1.0.0:419
  • Happy path tests DevFile

@RomanNikitenko RomanNikitenko marked this pull request as ready for review October 9, 2019 09:14
@sunix
Copy link
Contributor

sunix commented Oct 9, 2019

The changes are related to che tasks, so please try to run any che task from My Workspace panel and from Terminal -> Run Task menu as well

So this is working without your changes. So this is refactoring right ?

@RomanNikitenko
Copy link
Member Author

The changes are related to che tasks, so please try to run any che task from My Workspace panel and from Terminal -> Run Task menu as well

So this is working without your changes. So this is refactoring right ?

This is refactoring which allows to not lose runtime info at page refreshing.

@RomanNikitenko RomanNikitenko merged commit dd90ed5 into master Oct 10, 2019
@RomanNikitenko RomanNikitenko deleted the taskRuntimeInfo branch October 10, 2019 11:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants