Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isNullOrEmpty check to the BitbucketServerURLParser #653

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Feb 5, 2024

What does this PR do?

Add isNullOrEmpty check to the BitbucketServerURLParser. The che.integration.bitbucket.server_endpoints named parameter can be initialised as an empty string from the corresponding environment variable.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#22798

How to test this PR?

  1. Deploy che from the PR image: quay.io/eclipse/che-server:pr-653.
  2. Setup Bitbucket Cloud oauth secret.
  3. Add BitBucket Server Personal Access token.
  4. Start a workspace from the Bitbucket Server repository with a devfile.

See: Workspace starts successfully.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@vinokurig
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Feb 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, tolusha, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibuziuk ibuziuk merged commit 6f40c98 into main Feb 6, 2024
28 checks passed
@ibuziuk ibuziuk deleted the che-22798 branch February 6, 2024 13:18
@devstudio-release
Copy link

Build 3.13 :: server_3.x/324: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: server_3.12/2: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: server_3.12/2: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.12/68 triggered

@devstudio-release
Copy link

Build 3.12 :: update-digests_3.12/44: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.13 :: server_3.x/324: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/6190 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: get-sources-rhpkg-container-build_3.12/68: FAILURE

devspaces-operator-bundle : 3.12 :: Failed in 58722685 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.13 :: copyIIBsToQuay/2469: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.13 :: sync-to-downstream_3.x/6191: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/6107 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.13 :: operator-bundle_3.x/2648: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/6191 triggered

@devstudio-release
Copy link

Build 3.13 :: update-digests_3.x/5793: SUCCESS

Detected new images: rebuild operator-bundle
* server; /DS_CI/operator-bundle_3.x/2648 triggered

@devstudio-release
Copy link

Build 3.13 :: dsc_3.x/1800: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.13 :: dsc_3.x/1800: SUCCESS

3.13.0-CI

@devstudio-release
Copy link

Build 3.13 :: copyIIBsToQuay/2469: SUCCESS

3.13
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.13-8
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.13-v4.15-665372-s390x
  + quay.io/devspaces/iib:3.13-v4.15-s390x
  + quay.io/devspaces/iib:next-v4.15-s390x
  + quay.io/devspaces/iib:3.13-v4.14-665356-533291-s390x
  + quay.io/devspaces/iib:3.13-v4.13-665343-533286-s390x
  + quay.io/devspaces/iib:3.13-v4.12-666071-533281-s390x
  + quay.io/devspaces/iib:3.13-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.13-v4.15-665372-x86_64
  + quay.io/devspaces/iib:3.13-v4.14-665356-533291-x86_64
  + quay.io/devspaces/iib:3.13-v4.13-666085-533286-x86_64
  + quay.io/devspaces/iib:3.13-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.13-v4.12-666071-533281-x86_64
  + quay.io/devspaces/iib:3.13-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.13-v4.15-665372-ppc64le
  + quay.io/devspaces/iib:3.13-v4.14-665356-533291-ppc64le
  + quay.io/devspaces/iib:3.13-v4.13-666085-533286-ppc64le
  + quay.io/devspaces/iib:3.13-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.13-v4.12-666071-533281-ppc64le
  + quay.io/devspaces/iib:3.13-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find devfile error on starting a workspace from bitbucket-server
4 participants