-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isNullOrEmpty check to the BitbucketServerURLParser #653
Conversation
/retest |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk, tolusha, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.13 :: server_3.x/324: Console, Changes, Git Data |
Build 3.12 :: server_3.12/2: Console, Changes, Git Data |
Build 3.12 :: sync-to-downstream_3.12/68: Console, Changes, Git Data |
Build 3.13 :: sync-to-downstream_3.x/6190: Console, Changes, Git Data |
Build 3.12 :: push-latest-container-to-quay_3.12/15: Console, Changes, Git Data |
Build 3.12 :: get-sources-rhpkg-container-build_3.12/66: server : 3.12 :: Build 58721662 : quay.io/devspaces/server-rhel8:3.12-31 |
Build 3.12 :: server_3.12/2: Upstream sync done; /DS_CI/sync-to-downstream_3.12/68 triggered |
Build 3.12 :: update-digests_3.12/44: Console, Changes, Git Data |
Build 3.12 :: operator-bundle_3.12/44: Console, Changes, Git Data |
Build 3.13 :: push-latest-container-to-quay_3.x/4318: Console, Changes, Git Data |
Build 3.13 :: get-sources-rhpkg-container-build_3.x/6106: server : 3.x :: Build 58722159 : quay.io/devspaces/server-rhel8:3.13-2 |
Build 3.13 :: update-digests_3.x/5793: Console, Changes, Git Data |
Build 3.13 :: server_3.x/324: Upstream sync done; /DS_CI/sync-to-downstream_3.x/6190 triggered |
Build 3.12 :: sync-to-downstream_3.12/70: Console, Changes, Git Data |
Build 3.13 :: operator-bundle_3.x/2648: Console, Changes, Git Data |
Build 3.12 :: get-sources-rhpkg-container-build_3.12/68: devspaces-operator-bundle : 3.12 :: Failed in 58722685 : BREW:BUILD/STATUS:UNKNOWN |
Build 3.13 :: sync-to-downstream_3.x/6191: Console, Changes, Git Data |
Build 3.13 :: push-latest-container-to-quay_3.x/4319: Console, Changes, Git Data |
Build 3.13 :: copyIIBsToQuay/2469: Console, Changes, Git Data |
Build 3.13 :: sync-to-downstream_3.x/6191: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/6107 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.13 :: operator-bundle_3.x/2648: Upstream sync done; /DS_CI/sync-to-downstream_3.x/6191 triggered |
Build 3.13 :: update-digests_3.x/5793: Detected new images: rebuild operator-bundle |
Build 3.13 :: dsc_3.x/1800: Console, Changes, Git Data |
Build 3.13 :: dsc_3.x/1800: 3.13.0-CI |
What does this PR do?
Add isNullOrEmpty check to the BitbucketServerURLParser. The
che.integration.bitbucket.server_endpoints
named parameter can be initialised as an empty string from the corresponding environment variable.Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#22798
How to test this PR?
quay.io/eclipse/che-server:pr-653
.See: Workspace starts successfully.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.