Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert the kubernetes Secrets role due to the security vulnerability #58

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

vinokurig
Copy link
Contributor

Signed-off-by: Igor Vinokur [email protected]

What does this PR do?

Revert the kubernetes Secrets role due to the security vulnerability
see #44

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#19837

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@vinokurig vinokurig force-pushed the revertSecretsRole branch from 1291886 to 1757ae2 Compare July 20, 2021 09:04
@vinokurig vinokurig changed the title Revert the kubernetes Secrets role due to the security vulnerability fix: Revert the kubernetes Secrets role due to the security vulnerability Jul 20, 2021
@vinokurig vinokurig force-pushed the revertSecretsRole branch 2 times, most recently from 86c8826 to b9a0997 Compare July 20, 2021 09:14
@vinokurig vinokurig force-pushed the revertSecretsRole branch from b9a0997 to c01f551 Compare July 20, 2021 09:15
Copy link
Member

@sparkoo sparkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. we should collaborate, together with controller team, and find more secure solution to what you're trying to achieve on che-theia side.

@che-bot
Copy link
Contributor

che-bot commented Jul 20, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@vinokurig vinokurig merged commit 7a81693 into main Jul 20, 2021
@skabashnyuk skabashnyuk deleted the revertSecretsRole branch July 20, 2021 10:31
@che-bot che-bot added this to the 7.34 milestone Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants