Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to docker.io/golang:1.17.2-stretch to fix CVEs #1066

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

nickboldt
Copy link
Contributor

@nickboldt nickboldt commented Oct 7, 2021

What does this PR do?

chore: update to docker.io/golang:1.17.2-stretch to fix CVEs

image

Change-Id: I472529b6aad4af4c1d8b59d8bac84b7553ef0f56
Signed-off-by: nickboldt [email protected]

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

related to eclipse-che/che#20610

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Change-Id: I472529b6aad4af4c1d8b59d8bac84b7553ef0f56
Signed-off-by: nickboldt <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Click here to review and test in web IDE: Contribute

@nickboldt
Copy link
Contributor Author

@nickboldt nickboldt changed the title chore: update to... chore: update to docker.io/golang:1.16.8-stretch to fix CVEs Oct 7, 2021
Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to me to use golang:1.17.2-stretch. I've just tested it:
Screenshot from 2021-10-08 11-24-51

sidecars/go/Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Valeriy Svydenko <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 8, 2021

Click here to review and test in web IDE: Contribute

@nickboldt nickboldt changed the title chore: update to docker.io/golang:1.16.8-stretch to fix CVEs chore: update to docker.io/golang:1.17.2-stretch to fix CVEs Oct 8, 2021
@nickboldt nickboldt requested a review from svor October 8, 2021 12:05
@nickboldt
Copy link
Contributor Author

Followup in eclipse-che/che-devfile-registry#482

@openshift-ci
Copy link

openshift-ci bot commented Oct 8, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: benoitf, nickboldt, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svor svor merged commit 3e17ce4 into main Oct 8, 2021
@che-bot che-bot added this to the 7.38 milestone Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants