Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct CSVs and metadata #999

Merged
merged 10 commits into from
Sep 29, 2021
Merged

fix: correct CSVs and metadata #999

merged 10 commits into from
Sep 29, 2021

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Aug 9, 2021

Signed-off-by: Anatolii Bazko [email protected]

What does this PR do?

  • Add displayName for spec fields of CheCluster CRD
  • Add resources
  • Add alm-examples

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#20118

How to test this PR?

  1. operator-sdk scorecard bundle/next/eclipse-che-preview-openshift/ -o text --selector=test=olm-crds-have-resources-test
  2. operator-sdk scorecard bundle/next/eclipse-che-preview-openshift/ -o text --selector=test=olm-spec-descriptors-test

see https://sdk.operatorframework.io/docs/testing-operators/scorecard/

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@openshift-ci
Copy link

openshift-ci bot commented Aug 9, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Aug 9, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #999 (322a755) into main (d52d5ad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #999   +/-   ##
=======================================
  Coverage   53.92%   53.92%           
=======================================
  Files          67       67           
  Lines        8414     8414           
=======================================
  Hits         4537     4537           
  Misses       3404     3404           
  Partials      473      473           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52d5ad...322a755. Read the comment docs.

Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
@AndrienkoAleksandr
Copy link
Contributor

/retest

@AndrienkoAleksandr
Copy link
Contributor

/retest

@AndrienkoAleksandr
Copy link
Contributor

CI checks are green

@AndrienkoAleksandr AndrienkoAleksandr merged commit c43e9d6 into main Sep 29, 2021
@AndrienkoAleksandr AndrienkoAleksandr deleted the 20194 branch September 29, 2021 11:42
@che-bot che-bot added this to the 7.37 milestone Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants