Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CRW-1956: Rework tests for CRW #968

Merged
merged 6 commits into from
Jul 27, 2021
Merged

fix: CRW-1956: Rework tests for CRW #968

merged 6 commits into from
Jul 27, 2021

Conversation

Signed-off-by: Oleksandr Andriienko <[email protected]>
Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable except that there are merge conflicts :/

@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, nickboldt, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2021

@AndrienkoAleksandr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/v8-che-behind-proxy 88d8be1 link /test v8-che-behind-proxy
ci/prow/v8-multi-host-nightly-deployment 88d8be1 link /test v8-multi-host-nightly-deployment

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@AndrienkoAleksandr
Copy link
Contributor Author

/retest

Signed-off-by: Oleksandr Andriienko <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Jul 27, 2021
@AndrienkoAleksandr AndrienkoAleksandr changed the title CRW-1956: Rework tests for CRW fix: CRW-1956: Rework tests for CRW Jul 27, 2021
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
@tolusha tolusha merged commit 6c76cd8 into main Jul 27, 2021
@tolusha tolusha deleted the reworkTestsForCRW branch July 27, 2021 14:30
@che-bot che-bot added this to the 7.34 milestone Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants