fix: Remove previous RELATED_IMAGES before adding new ones #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatolii Bazko <[email protected]>
tolusha
requested review from
AndrienkoAleksandr,
flacatus,
mmorhun and
nickboldt
as code owners
flacatus
approved these changes
Jul 26, 2021
mmorhun
reviewed
Jul 26, 2021
| envVarName=$(cat "${OPERATOR_FILE}" | yq -r '.spec.template.spec.containers[0].env['${i}'].name') | ||
| if [[ ${envVarName} =~ plugin_registry_image ]] || [[ ${envVarName} =~ devfile_registry_image ]]; then | ||
| yq -riY 'del(.spec.template.spec.containers[0].env['${i}'])' ${OPERATOR_FILE} | ||
| i=$((i-1)) |
There was a problem hiding this comment.
- I'd remove this decrement and put the following increment into else block.
- Shouldn't you change the total number of env vars too?
There was a problem hiding this comment.
- I've thought about it but this approach sounds more explicit
- It does not matter, there are no errors,
yqreturnsnullas a string
There was a problem hiding this comment.
- I have opposite opinion, but ok.
- That's logically wrong.
There was a problem hiding this comment.
- It is not a c++ or java. We have to processed all records, other doesn't matter
There was a problem hiding this comment.
That's a source of errors. If yq behavior changes or someone add another line that doesn't tolerate index error... but up to you...
mmorhun
approved these changes
Jul 26, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: flacatus, mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatolii Bazko [email protected]
What does this PR do?
Remove previous RELATED_IMAGES before adding new ones to
config/manager/manager.yamlScreenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#20171
How to test this PR?
Run twice, make sure that content of the
config/manager/manager.yamlis not changes after the second try../olm/addDigests.sh -w . -s bundle/stable/eclipse-che-preview-openshift/manifests/che-operator.clusterserviceversion.yaml -o config/manager/manager.yaml -t 7.32.0PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.