-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Import Devworkspace Che Operator #925
Conversation
…loyment and make sure ingresses don't enter an infinite reconcile loop.
/retest |
/test v7-stable-to-nightly |
1 similar comment
/test v7-stable-to-nightly |
|
|
I've tested update from 7.34.0 into this PR version, and it works fine. However, I don't know details of the CI test deployment. I don't have imagepuller enabled (I guess, I don't know how to do it). cc: @tolusha |
/retest |
1 similar comment
/retest |
I will take a look |
Here is a test script which is run on OpenShift CI. [1] https://github.com/eclipse-che/che-operator/blob/main/.ci/oci-nightly-update.sh |
@tolusha @metlos @sparkoo #925 (comment) all CQs has been approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't be available until end of the week. I have no more comments to this issue except failing CI job, which I don't know how to properly fix. I have tested the PR and it is working fine for me. So I'm giving it a green.
@tolusha please feel free to merge when you're happy with the PR
Signed-off-by: Anatolii Bazko <[email protected]>
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: metlos, sparkoo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test v8-multi-host-next-deployment |
What does this PR do?
This imports the Devworkspace Che Operator as a new controller inside
che-operator
.The minimum amount of changes have been made to both codebases for the stuff to work.
In another words, the new controller
pkg/controller/devworkspace
is essentially stillcompletely standalone. It even still runs in its own reconcile loop even though it
reconciles
CheCluster
which is also reconciled by the mainche
controller.The significant changes are are concentrated in
cmd/manager/main.go
, which sets the wholeshow up.
In
pkg/deploy/dev-workspace
, we have a new approach for installing the devworkspace support.The operator exits after a successfull installation, relying on Kubernetes to restart it.
When intialized again, it sees the CRDs for devworkspaces present in the cluster and
initializes the devworkspace reconciler.
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#19408
How to test this PR?
quay.io/lkrejci/che-operator:issue-19408
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.