-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't set public url value to internal url settings. #891
fix: Don't set public url value to internal url settings. #891
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
fab4889
to
d509c95
Compare
Codecov Report
@@ Coverage Diff @@
## main #891 +/- ##
==========================================
- Coverage 50.08% 50.02% -0.06%
==========================================
Files 56 56
Lines 6817 6809 -8
==========================================
- Hits 3414 3406 -8
Misses 3037 3037
Partials 366 366
Continue to review full report at Codecov.
|
Signed-off-by: Oleksandr Andriienko <[email protected]>
d509c95
to
d4ac2b2
Compare
devworkspace tests part failed. |
Signed-off-by: Oleksandr Andriienko <[email protected]>
…etPublicUrlValueToInternalUrlSettings
/retest |
@AndrienkoAleksandr: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What does this PR do?
Don't set public url value to internal url settings.
What issues does this PR fix or reference?
eclipse-che/che#18643
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.
Signed-off-by: Oleksandr Andriienko [email protected]