Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't set public url value to internal url settings. #891

Merged
merged 3 commits into from
Aug 3, 2021

Conversation

@openshift-ci
Copy link

openshift-ci bot commented Jul 7, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jul 28, 2021

New changes are detected. LGTM label has been removed.

@AndrienkoAleksandr AndrienkoAleksandr force-pushed the dontSetPublicUrlValueToInternalUrlSettings branch from fab4889 to d509c95 Compare July 28, 2021 20:02
@AndrienkoAleksandr AndrienkoAleksandr changed the title Don't set public url value to internal url settings. fix: Don't set public url value to internal url settings. Jul 28, 2021
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #891 (d509c95) into main (10f18a9) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head d509c95 differs from pull request most recent head d4ac2b2. Consider uploading reports for the commit d4ac2b2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #891      +/-   ##
==========================================
- Coverage   50.08%   50.02%   -0.06%     
==========================================
  Files          56       56              
  Lines        6817     6809       -8     
==========================================
- Hits         3414     3406       -8     
  Misses       3037     3037              
  Partials      366      366              
Impacted Files Coverage Δ
pkg/deploy/server/server_configmap.go 84.89% <100.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10f18a9...d4ac2b2. Read the comment docs.

@AndrienkoAleksandr AndrienkoAleksandr force-pushed the dontSetPublicUrlValueToInternalUrlSettings branch from d509c95 to d4ac2b2 Compare August 2, 2021 01:15
@tolusha
Copy link
Contributor

tolusha commented Aug 2, 2021

devworkspace tests part failed.

@tolusha
Copy link
Contributor

tolusha commented Aug 3, 2021

/retest

@openshift-ci
Copy link

openshift-ci bot commented Aug 3, 2021

@AndrienkoAleksandr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/v8-che-behind-proxy a8ec192 link /test v8-che-behind-proxy
ci/prow/v7-stable-to-nightly a8ec192 link /test v7-stable-to-nightly

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@AndrienkoAleksandr AndrienkoAleksandr merged commit df77efd into main Aug 3, 2021
@AndrienkoAleksandr AndrienkoAleksandr deleted the dontSetPublicUrlValueToInternalUrlSettings branch August 3, 2021 07:22
@che-bot che-bot added this to the 7.35 milestone Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants