Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not delete internal backup server on backup CR deletion #888

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Jul 2, 2021

What does this PR do?

Do not set controller references on objects created by backup controller that are related to internal backup server in order to be able to reuse it for several backups in a row.

What issues does this PR fix or reference?

eclipse-che/che#18703
eclipse-che/che#19932

How to test this PR?

  1. Schedule a backup by creating backup custom resource:
apiVersion: org.eclipse.che/v1
kind: CheClusterBackup
metadata:
  name: eclipse-che-backup
spec:
  useInternalBackupServer: true
  1. Delete created backup CR after backup successfully finishes.
  2. Make sure that internal backup server resources (deployment, backup server config and secrets) are not deleted.
  3. Request another backup by creating backup CR again
  4. Check that new backup created.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@mmorhun mmorhun requested review from nickboldt and tolusha as code owners July 2, 2021 13:11
@mmorhun mmorhun self-assigned this Jul 2, 2021
@mmorhun mmorhun force-pushed the che-19932 branch 2 times, most recently from 78fd30c to 486bea9 Compare July 2, 2021 14:26
@mmorhun mmorhun force-pushed the che-19932 branch 2 times, most recently from 7e64c09 to b5bb424 Compare July 2, 2021 14:40
@mmorhun
Copy link
Contributor Author

mmorhun commented Jul 2, 2021

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jul 2, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha
Copy link
Contributor

tolusha commented Jul 2, 2021

@mmorhun
I would like to see some unit tests

@tolusha
Copy link
Contributor

tolusha commented Jul 7, 2021

/retest

@tolusha tolusha mentioned this pull request Jul 7, 2021
24 tasks
@tolusha tolusha changed the title Do not delete internal backup server on backup CR deletion fix: Do not delete internal backup server on backup CR deletion Jul 7, 2021
Signed-off-by: Mykola Morhun <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Jul 7, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Jul 7, 2021

@mmorhun: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v7-single-host-nightly-deployment 4ffa99e link /test v7-single-host-nightly-deployment
ci/prow/v7-multi-host-nightly-deployment 4ffa99e link /test v7-multi-host-nightly-deployment
ci/prow/v8-multi-host-nightly-deployment 4ffa99e link /test v8-multi-host-nightly-deployment
ci/prow/v8-single-host-nightly-deployment 4ffa99e link /test v8-single-host-nightly-deployment

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mmorhun
Copy link
Contributor Author

mmorhun commented Jul 7, 2021

Tests are failing due to eclipse-che/che#20072

@mmorhun mmorhun merged commit fc2b559 into main Jul 7, 2021
@mmorhun mmorhun deleted the che-19932 branch July 7, 2021 14:11
@che-bot che-bot added this to the 7.33 milestone Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants