Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ensure that che-server's SA have enough permission to manipulate with devworkspaces resource on kubernetes #858

Merged
merged 6 commits into from
Jun 8, 2021

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jun 7, 2021

Signed-off-by: Anatolii Bazko [email protected]

What does this PR do?

che-operator delegates some permissions to manipulates with devworkspace resources

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#19920

How to test this PR?

  1. deploy Eclipse Che
  2. check if eclipse-che-cheworkspaces-devworkspace-clusterrole cluster role & cluster role binding are created

Image to test: docker.io/abazko/operator:19920

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorhun mmorhun removed their assignment Jun 7, 2021
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #858 (73bbe3a) into main (8740c19) will decrease coverage by 0.03%.
The diff coverage is 40.62%.

❗ Current head 73bbe3a differs from pull request most recent head dcfff66. Consider uploading reports for the commit dcfff66 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
- Coverage   46.65%   46.61%   -0.04%     
==========================================
  Files          53       53              
  Lines        5322     5354      +32     
==========================================
+ Hits         2483     2496      +13     
- Misses       2529     2545      +16     
- Partials      310      313       +3     
Impacted Files Coverage Δ
...g/controller/che/workspace_namespace_permission.go 69.78% <40.62%> (-6.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad643a...dcfff66. Read the comment docs.

@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Jun 7, 2021
tolusha added 6 commits June 7, 2021 18:12
…ate with devworkspaces resource on kubernetes

Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
@tolusha
Copy link
Contributor Author

tolusha commented Jun 8, 2021

/retest

@tolusha tolusha merged commit 105c04e into main Jun 8, 2021
@tolusha tolusha deleted the 19920 branch June 8, 2021 13:50
@che-bot che-bot added this to the 7.32 milestone Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants