-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Ensure that che-server's SA have enough permission to manipulate with devworkspaces resource on kubernetes #858
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #858 +/- ##
==========================================
- Coverage 46.65% 46.61% -0.04%
==========================================
Files 53 53
Lines 5322 5354 +32
==========================================
+ Hits 2483 2496 +13
- Misses 2529 2545 +16
- Partials 310 313 +3
Continue to review full report at Codecov.
|
New changes are detected. LGTM label has been removed. |
…ate with devworkspaces resource on kubernetes Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
/retest |
Signed-off-by: Anatolii Bazko [email protected]
What does this PR do?
che-operator delegates some permissions to manipulates with devworkspace resources
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#19920
How to test this PR?
eclipse-che-cheworkspaces-devworkspace-clusterrole
cluster role & cluster role binding are createdImage to test:
docker.io/abazko/operator:19920
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.