Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dashboard ingress configuration with custom cheHost #856

Merged
merged 5 commits into from
Jun 7, 2021

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jun 4, 2021

tolusha added 5 commits June 4, 2021 14:24
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
@tolusha tolusha mentioned this pull request Jun 4, 2021
47 tasks
@tolusha tolusha changed the title Fixexposewithcustomhost fix: dashboard ingress configuration with custom cheHost Jun 4, 2021
@tolusha
Copy link
Contributor Author

tolusha commented Jun 5, 2021

/retest

1 similar comment
@tolusha
Copy link
Contributor Author

tolusha commented Jun 6, 2021

/retest

@codecov
Copy link

codecov bot commented Jun 6, 2021

Codecov Report

Merging #856 (c8823b7) into main (e83454a) will increase coverage by 0.06%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #856      +/-   ##
==========================================
+ Coverage   46.65%   46.72%   +0.06%     
==========================================
  Files          53       53              
  Lines        5322     5327       +5     
==========================================
+ Hits         2483     2489       +6     
+ Misses       2529     2528       -1     
  Partials      310      310              
Impacted Files Coverage Δ
pkg/deploy/identity-provider/identity_provider.go 12.50% <0.00%> (-0.08%) ⬇️
pkg/deploy/ingress.go 62.92% <42.85%> (+2.24%) ⬆️
pkg/deploy/route.go 68.96% <87.50%> (+2.29%) ⬆️
pkg/deploy/dashboard/dashboard.go 61.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e83454a...c8823b7. Read the comment docs.

@openshift-ci openshift-ci bot added the lgtm label Jun 7, 2021
@mmorhun mmorhun removed their assignment Jun 7, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants