Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow to upgrade che 7.31 or later to upgrade installation that configured with namespace strategies other than "per user" #818

Merged
merged 5 commits into from
May 12, 2021

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented May 7, 2021

Signed-off-by: Anatolii Bazko [email protected]

What does this PR do?

  • Do not allow to upgrade che 7.31 or later to upgrade installation that configured with namespace strategies other than "per user"
  • Operator delegates permissions that are needed to start a workspace in a dedicated namespace
  • Previous permissions (that are needed to start a workspace in the same namespace) are not removed to allow to start previously created workspaces

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#19537

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

@abazko: Manually checked updates to per-user namespace strategy. New and previously workspaces are started on both k8s and OpenShift clusters.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha mentioned this pull request May 7, 2021
41 tasks
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #818 (d8a76e3) into main (e85c6a1) will decrease coverage by 0.31%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #818      +/-   ##
==========================================
- Coverage   45.36%   45.04%   -0.32%     
==========================================
  Files          54       54              
  Lines        5348     5288      -60     
==========================================
- Hits         2426     2382      -44     
- Misses       2597     2605       +8     
+ Partials      325      301      -24     
Impacted Files Coverage Δ
pkg/controller/che/che_cr_validator.go 0.00% <0.00%> (-25.00%) ⬇️
pkg/deploy/identity-provider/exec.go 0.00% <0.00%> (ø)
pkg/util/util.go 12.00% <0.00%> (ø)
pkg/controller/che/che_controller.go 19.65% <22.22%> (-0.04%) ⬇️
pkg/deploy/defaults.go 49.33% <33.33%> (-0.67%) ⬇️
pkg/deploy/dev-workspace/dev_workspace.go 69.50% <33.33%> (-1.61%) ⬇️
pkg/deploy/server/che_configmap.go 82.90% <35.71%> (-0.27%) ⬇️
...g/controller/che/workspace_namespace_permission.go 74.66% <100.00%> (+3.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae699a7...d8a76e3. Read the comment docs.

tolusha added 4 commits May 12, 2021 11:53
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
@tolusha
Copy link
Contributor Author

tolusha commented May 12, 2021

/retest

Signed-off-by: Anatolii Bazko <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label May 12, 2021
@openshift-ci openshift-ci bot added the lgtm label May 12, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 12, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit 07c4f74 into main May 12, 2021
@tolusha tolusha deleted the 19537 branch May 12, 2021 12:53
tolusha added a commit that referenced this pull request May 18, 2021
…t configured with namespace strategies other than "per user" (#818)

* Don't support another than per-user strategy

Signed-off-by: Anatolii Bazko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants