Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Che Operator should be able to install the Devworkspace che operator #707

Merged
merged 9 commits into from
Mar 11, 2021
Merged

Che Operator should be able to install the Devworkspace che operator #707

merged 9 commits into from
Mar 11, 2021

Conversation

skabashnyuk
Copy link
Contributor

@skabashnyuk skabashnyuk commented Mar 5, 2021 •
edited by tolusha
Loading

@openshift-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov
Copy link

codecov bot commented Mar 5, 2021 •
edited
Loading

Codecov Report

Merging #707 (593ba00) into master (d2e4ba9) will increase coverage by 0.42%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #707      +/-   ##
==========================================
+ Coverage   32.68%   33.10%   +0.42%     
==========================================
  Files          50       50              
  Lines        5452     5500      +48     
==========================================
+ Hits         1782     1821      +39     
- Misses       3402     3408       +6     
- Partials      268      271       +3
Impacted Files Coverage Δ
pkg/deploy/dev-workspace/dev_workspace.go 77.47% <81.25%> (+2.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e4ba9...593ba00. Read the comment docs.

metlos
metlos reviewed Mar 5, 2021
View reviewed changes
Dockerfile Show resolved Hide resolved
@l0rd l0rd mentioned this pull request Mar 5, 2021
Closed
24 tasks
@metlos metlos requested a review from tolusha March 9, 2021 22:44
@metlos metlos marked this pull request as ready for review March 9, 2021 22:45
tolusha
tolusha reviewed Mar 10, 2021
View reviewed changes
Dockerfile Show resolved Hide resolved
deploy/cluster_role.yaml Show resolved Hide resolved
deploy/cluster_role.yaml Outdated Show resolved Hide resolved
deploy/cluster_role.yaml Outdated Show resolved Hide resolved
deploy/cluster_role.yaml Outdated Show resolved Hide resolved
local-debug.sh Outdated Show resolved Hide resolved
make-release.sh Show resolved Hide resolved
pkg/deploy/dev-workspace/dev_workspace.go Show resolved Hide resolved
pkg/deploy/dev-workspace/dev_workspace.go Show resolved Hide resolved
pkg/deploy/dev-workspace/dev_workspace_test.go Show resolved Hide resolved
@tolusha
Copy link
Contributor

tolusha commented Mar 10, 2021

Sounds good. pls find some minor remarks above.

@tolusha
Copy link
Contributor

tolusha commented Mar 10, 2021

  • rebased on master
  • updated nightly bundle

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skabashnyuk, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metlos metlos merged commit e0ff1bf into master Mar 11, 2021
@metlos metlos deleted the che19142 branch March 11, 2021 08:13
@che-bot che-bot added this to the 7.27 milestone Mar 11, 2021
tolusha added a commit that referenced this pull request Mar 11, 2021
@skabashnyuk @metlos @tolusha
Che Operator should be able to install the Devworkspace che operator (#…
4705ee7 
…707)

Teach Che operator to install devworkspace-che-operator alongside with devworkspace-operator when devworkspaces are enabled.

Signed-off-by: Anatolii Bazko <[email protected]>

Co-authored-by: Sergii Kabashniuk <[email protected]>
Co-authored-by: Lukas Krejci <[email protected]>
Co-authored-by: Anatolii Bazko <[email protected]>
tolusha added a commit that referenced this pull request Mar 12, 2021
@tolusha @metlos
Enable to deploy dev workspace and che dev workspace operator (#713)
7d17f94 
* Che operator should be able to install DevWorkspace operator (#689)

* Che Operator should be able to install the Devworkspace che operator (#707)

Signed-off-by: Anatolii Bazko <[email protected]>

Co-authored-by: Sergii Kabashniuk <[email protected]>
Co-authored-by: Lukas Krejci <[email protected]>
Co-authored-by: Anatolii Bazko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metlos metlos metlos left review comments

@tolusha tolusha tolusha approved these changes

@AndrienkoAleksandr AndrienkoAleksandr Awaiting requested review from AndrienkoAleksandr

@flacatus flacatus Awaiting requested review from flacatus

@mmorhun mmorhun Awaiting requested review from mmorhun

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees

@tolusha tolusha

Labels
lgtm
Projects
None yet
Milestone
7.27
Development

Successfully merging this pull request may close these issues.

Che Operator should be able to install the Devworkspace che operator
5 participants
@skabashnyuk @openshift-ci-robot @tolusha @metlos @che-bot