Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'SecurityContext' of Containers into diff ignore on Deployments comparison #635

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Add 'SecurityContext' of Containers into diff ignore on Deployments comparison #635

merged 1 commit into from
Jan 19, 2021

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Jan 19, 2021 •
edited
Loading

Signed-off-by: Mykola Morhun [email protected]

What does this PR do?

Adds SecurityContext of Containers field of pod template spec of Deployment into ignore list.
This will prevent from infinite loop in Operator when infrastructure sets own defaults (so operator will ignore that and will not try to set own value against platform defaults).

What issues does this PR fix or reference?

Should fix eclipse-che/che#18828

How to test this PR?

Use image built from this PR within CRW CCI

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@mmorhun mmorhun self-assigned this Jan 19, 2021
@codecov
Copy link

codecov bot commented Jan 19, 2021 •
edited
Loading

Codecov Report

Merging #635 (40cd077) into master (de5560b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #635   +/-   ##
=======================================
  Coverage   14.24%   14.24%           
=======================================
  Files          37       37           
  Lines        4247     4247           
=======================================
  Hits          605      605           
  Misses       3503     3503           
  Partials      139      139
Impacted Files Coverage Δ
pkg/deploy/deployment.go 44.79% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de5560b...40cd077. Read the comment docs.

dmytro-ndp
dmytro-ndp approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installation of Eclipse Che by using docker.io/mm4eche/che-operator:latest has finished successfully on CRW CCI infrastructure:

+ /mnt/hudson_workspace/workspace/basic-MultiUser-Che-check-e2e-tests-against-k8s/chectl server:deploy --k8spodreadytimeout=600000 --k8spodwaittimeout=600000 --k8spoddownloadimagetimeout=600000 --listr-renderer=verbose --platform=minikube --che-operator-cr-patch-yaml=/mnt/hudson_workspace/workspace/basic-MultiUser-Che-check-e2e-tests-against-k8s/custom-resource-patch.yaml --telemetry=off --chenamespace=eclipse-che --che-operator-image=docker.io/mm4eche/che-operator:latest
› Current Kubernetes context: 'minikube'
(node:17622) Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0' makes TLS connections and HTTPS requests insecure by disabling certificate verification.
› Installer type is set to: 'operator'
[10:03:52] Verify Kubernetes API [started]
[10:03:52] Verify Kubernetes API...OK [title changed]
[10:03:52] Verify Kubernetes API...OK [completed]
[10:03:52] 👀  Looking for an already existing Eclipse Che instance [started]
[10:03:52] Verify if Eclipse Che is deployed into namespace "eclipse-che" [started]
[10:03:52] Verify if Eclipse Che is deployed into namespace "eclipse-che"...it is not [title changed]
[10:03:52] Verify if Eclipse Che is deployed into namespace "eclipse-che"...it is not [completed]
[10:03:52] 👀  Looking for an already existing Eclipse Che instance [completed]
[10:03:52] ✈️  Minikube preflight checklist [started]
[10:03:52] Verify if kubectl is installed [started]
[10:03:52] Verify if kubectl is installed [completed]
[10:03:52] Verify if minikube is installed [started]
[10:03:52] Verify if minikube is installed [completed]
[10:03:52] Verify if minikube is running [started]
[10:03:52] Verify if minikube is running [completed]
[10:03:52] Start minikube [started]
[10:03:52] Start minikube [skipped]
[10:03:52] → Minikube is already running.
[10:03:52] Check Kubernetes version [started]
[10:03:53] Check Kubernetes version: Found v1.14.3. [title changed]
[10:03:53] Check Kubernetes version: Found v1.14.3. [completed]
[10:03:53] Verify if minikube ingress addon is enabled [started]
[10:03:53] Verify if minikube ingress addon is enabled [completed]
[10:03:53] Enable minikube ingress addon [started]
[10:03:53] Enable minikube ingress addon [skipped]
[10:03:53] → Ingress addon is already enabled.
[10:03:53] Retrieving minikube IP and domain for ingress URLs [started]
[10:03:53] Retrieving minikube IP and domain for ingress URLs...10.0.103.138.nip.io. [title changed]
[10:03:53] Retrieving minikube IP and domain for ingress URLs...10.0.103.138.nip.io. [completed]
[10:03:53] Checking minikube version [started]
[10:03:53] Checking minikube version... 1.1.1 [title changed]
[10:03:53] Checking minikube version... 1.1.1 [completed]
[10:03:53] Check if cluster accessible [started]
[10:03:53] Check if cluster accessible [skipped]
[10:03:53] ✈️  Minikube preflight checklist [completed]
[10:03:53] Following Eclipse Che logs [started]
[10:03:53] Start following Operator logs [started]
[10:03:53] Start following Operator logs...done [title changed]
[10:03:53] Start following Operator logs...done [completed]
[10:03:53] Start following Eclipse Che server logs [started]
[10:03:53] Start following Eclipse Che server logs...done [title changed]
[10:03:53] Start following Eclipse Che server logs...done [completed]
[10:03:53] Start following Postgres logs [started]
[10:03:53] Start following Postgres logs...done [title changed]
[10:03:53] Start following Postgres logs...done [completed]
[10:03:53] Start following Keycloak logs [started]
[10:03:53] Start following Keycloak logs...done [title changed]
[10:03:53] Start following Keycloak logs...done [completed]
[10:03:53] Start following Plugin registry logs [started]
[10:03:53] Start following Plugin registry logs...done [title changed]
[10:03:53] Start following Plugin registry logs...done [completed]
[10:03:53] Start following Devfile registry logs [started]
[10:03:53] Start following Devfile registry logs...done [title changed]
[10:03:53] Start following Devfile registry logs...done [completed]
[10:03:53] Start following namespace events [started]
[10:03:53] Start following namespace events...done [title changed]
[10:03:53] Start following namespace events...done [completed]
[10:03:53] Following Eclipse Che logs [completed]
[10:03:53] 🏃‍  Running the Eclipse Che operator [started]
[10:03:53] Copying operator resources [started]
[10:03:53] Copying operator resources...done. [title changed]
[10:03:53] Copying operator resources...done. [completed]
[10:03:53] Create Namespace (eclipse-che) [started]
[10:03:53] Create Namespace (eclipse-che)...Done. [title changed]
[10:03:53] Create Namespace (eclipse-che)...Done. [completed]
[10:03:53] Create ServiceAccount che-operator in namespace eclipse-che [started]
[10:03:53] Create ServiceAccount che-operator in namespace eclipse-che...done. [title changed]
[10:03:53] Create ServiceAccount che-operator in namespace eclipse-che...done. [completed]
[10:03:53] Create Role che-operator in namespace eclipse-che [started]
[10:03:53] Create Role che-operator in namespace eclipse-che...done. [title changed]
[10:03:53] Create Role che-operator in namespace eclipse-che...done. [completed]
[10:03:53] Create ClusterRole eclipse-che-che-operator [started]
[10:03:53] Create ClusterRole eclipse-che-che-operator...done. [title changed]
[10:03:53] Create ClusterRole eclipse-che-che-operator...done. [completed]
[10:03:53] Create ClusterRole eclipse-che-che-namespace-editor [started]
[10:03:53] Create ClusterRole eclipse-che-che-namespace-editor...done. [title changed]
[10:03:53] Create ClusterRole eclipse-che-che-namespace-editor...done. [completed]
[10:03:53] Create ClusterRoleBinding eclipse-che-che-operator-namespace-editor [started]
[10:03:53] Create ClusterRoleBinding eclipse-che-che-operator-namespace-editor...done. [title changed]
[10:03:53] Create ClusterRoleBinding eclipse-che-che-operator-namespace-editor...done. [completed]
[10:03:53] Create RoleBinding che-operator in namespace eclipse-che [started]
[10:03:53] Create RoleBinding che-operator in namespace eclipse-che...done. [title changed]
[10:03:53] Create RoleBinding che-operator in namespace eclipse-che...done. [completed]
[10:03:53] Create ClusterRoleBinding eclipse-che-che-operator [started]
[10:03:53] Create ClusterRoleBinding eclipse-che-che-operator...done. [title changed]
[10:03:53] Create ClusterRoleBinding eclipse-che-che-operator...done. [completed]
[10:03:53] Create CRD checlusters.org.eclipse.che [started]
[10:03:53] Create CRD checlusters.org.eclipse.che...done. [title changed]
[10:03:53] Create CRD checlusters.org.eclipse.che...done. [completed]
[10:03:53] Waiting 5 seconds for the new Kubernetes resources to get flushed [started]
[10:03:58] Waiting 5 seconds for the new Kubernetes resources to get flushed...done. [title changed]
[10:03:58] Waiting 5 seconds for the new Kubernetes resources to get flushed...done. [completed]
[10:03:58] Create deployment che-operator in namespace eclipse-che [started]
[10:03:58] Create deployment che-operator in namespace eclipse-che...done. [title changed]
[10:03:58] Create deployment che-operator in namespace eclipse-che...done. [completed]
[10:03:58] Operator pod bootstrap [started]
[10:03:58] Scheduling [started]
[10:03:58] Scheduling...done [title changed]
[10:03:58] Scheduling...done [completed]
[10:03:58] Downloading images [started]
[10:04:04] Downloading images...done [title changed]
[10:04:04] Downloading images...done [completed]
[10:04:04] Starting [started]
[10:04:15] Starting...done [title changed]
[10:04:15] Starting...done [completed]
[10:04:15] Operator pod bootstrap [completed]
[10:04:15] Prepare Eclipse Che cluster CR [started]
[10:04:15] Prepare Eclipse Che cluster CR...Done. [title changed]
[10:04:15] Prepare Eclipse Che cluster CR...Done. [completed]
[10:04:15] Create the Custom Resource of type checlusters.org.eclipse.che in the namespace eclipse-che [started]
[10:04:15] Create the Custom Resource of type checlusters.org.eclipse.che in the namespace eclipse-che...done. [title changed]
[10:04:15] Create the Custom Resource of type checlusters.org.eclipse.che in the namespace eclipse-che...done. [completed]
[10:04:15] 🏃‍  Running the Eclipse Che operator [completed]
[10:04:15] ✅  Post installation checklist [started]
[10:04:15] PostgreSQL pod bootstrap [started]
[10:04:15] Scheduling [started]
[10:04:20] Scheduling...done [title changed]
[10:04:20] Scheduling...done [completed]
[10:04:20] Downloading images [started]
[10:04:22] Downloading images...done [title changed]
[10:04:22] Downloading images...done [completed]
[10:04:22] Starting [started]
[10:04:37] Starting...done [title changed]
[10:04:37] Starting...done [completed]
[10:04:37] PostgreSQL pod bootstrap [completed]
[10:04:37] Keycloak pod bootstrap [started]
[10:04:37] Scheduling [started]
[10:04:38] Scheduling...done [title changed]
[10:04:38] Scheduling...done [completed]
[10:04:38] Downloading images [started]
[10:04:51] Downloading images...done [title changed]
[10:04:51] Downloading images...done [completed]
[10:04:51] Starting [started]
[10:05:24] Starting...done [title changed]
[10:05:24] Starting...done [completed]
[10:05:24] Keycloak pod bootstrap [completed]
[10:05:24] Devfile registry pod bootstrap [started]
[10:05:24] Scheduling [started]
[10:06:05] Scheduling...done [title changed]
[10:06:05] Scheduling...done [completed]
[10:06:05] Downloading images [started]
[10:06:08] Downloading images...done [title changed]
[10:06:08] Downloading images...done [completed]
[10:06:08] Starting [started]
[10:06:17] Starting...done [title changed]
[10:06:17] Starting...done [completed]
[10:06:17] Devfile registry pod bootstrap [completed]
[10:06:17] Plugin registry pod bootstrap [started]
[10:06:17] Scheduling [started]
[10:06:17] Scheduling...done [title changed]
[10:06:17] Scheduling...done [completed]
[10:06:17] Downloading images [started]
[10:06:19] Downloading images...done [title changed]
[10:06:19] Downloading images...done [completed]
[10:06:19] Starting [started]
[10:06:21] Starting...done [title changed]
[10:06:21] Starting...done [completed]
[10:06:21] Plugin registry pod bootstrap [completed]
[10:06:21] Eclipse Che pod bootstrap [started]
[10:06:21] Scheduling [started]
[10:06:21] Scheduling...done [title changed]
[10:06:21] Scheduling...done [completed]
[10:06:21] Downloading images [started]
[10:06:22] Downloading images...done [title changed]
[10:06:22] Downloading images...done [completed]
[10:06:22] Starting [started]
[10:06:54] Starting...done [title changed]
[10:06:54] Starting...done [completed]
[10:06:54] Eclipse Che pod bootstrap [completed]
[10:06:54] Eclipse Che status check [started]
[10:06:54] Eclipse Che status check...done [title changed]
[10:06:54] Eclipse Che status check...done [completed]
[10:06:54] ✅  Post installation checklist [completed]
[10:06:54] Retrieving Keycloak admin credentials [started]
[10:06:54] Retrieving Keycloak admin credentials...done [title changed]
[10:06:54] Retrieving Keycloak admin credentials...done [completed]
[10:06:54] Retrieving Che self-signed CA certificate [started]
[10:06:54] Retrieving Che self-signed CA certificate... done [title changed]
[10:06:54] Retrieving Che self-signed CA certificate... done [completed]
[10:06:54] Prepare post installation output [started]
[10:06:54] Prepare post installation output...done [title changed]
[10:06:54] Prepare post installation output...done [completed]
[10:06:54] Show important messages [started]
[10:06:54] Eclipse Che 7.25.0-SNAPSHOT has been successfully deployed. [started]
[10:06:54] Eclipse Che 7.25.0-SNAPSHOT has been successfully deployed. [completed]
[10:06:54] Documentation             : https://www.eclipse.org/che/docs/ [started]
[10:06:54] Documentation             : https://www.eclipse.org/che/docs/ [completed]
[10:06:54] ------------------------------------------------------------------------------- [started]
[10:06:54] ------------------------------------------------------------------------------- [completed]
[10:06:54] Users Dashboard           : https://che-eclipse-che.10.0.103.138.nip.io [started]
[10:06:54] Users Dashboard           : https://che-eclipse-che.10.0.103.138.nip.io [completed]
[10:06:54] Admin user login          : "admin:admin". NOTE: must change after first login. [started]
[10:06:54] Admin user login          : "admin:admin". NOTE: must change after first login. [completed]
[10:06:54] ------------------------------------------------------------------------------- [started]
[10:06:54] ------------------------------------------------------------------------------- [completed]
[10:06:54] Plug-in Registry          : https://plugin-registry-eclipse-che.10.0.103.138.nip.io/v3 [started]
[10:06:54] Plug-in Registry          : https://plugin-registry-eclipse-che.10.0.103.138.nip.io/v3 [completed]
[10:06:54] Devfile Registry          : https://devfile-registry-eclipse-che.10.0.103.138.nip.io [started]
[10:06:54] Devfile Registry          : https://devfile-registry-eclipse-che.10.0.103.138.nip.io [completed]
[10:06:54] ------------------------------------------------------------------------------- [started]
[10:06:54] ------------------------------------------------------------------------------- [completed]
[10:06:54] Identity Provider URL     : https://keycloak-eclipse-che.10.0.103.138.nip.io/auth [started]
[10:06:54] Identity Provider URL     : https://keycloak-eclipse-che.10.0.103.138.nip.io/auth [completed]
[10:06:54] Identity Provider login   : "admin:zzsYoPnfAyEf". [started]
[10:06:54] Identity Provider login   : "admin:zzsYoPnfAyEf". [completed]
[10:06:54] ------------------------------------------------------------------------------- [started]
[10:06:54] ------------------------------------------------------------------------------- [completed]
[10:06:54] �[33m[ACTION REQUIRED]�[39m Please add Che self-signed CA certificate into your browser: /tmp/cheCA.crt.
Documentation how to add a CA certificate into a browser: https://www.eclipse.org/che/docs/che-7/overview/importing-certificates-to-browsers/ [started]
[10:06:54] �[33m[ACTION REQUIRED]�[39m Please add Che self-signed CA certificate into your browser: /tmp/cheCA.crt.
Documentation how to add a CA certificate into a browser: https://www.eclipse.org/che/docs/che-7/overview/importing-certificates-to-browsers/ [completed]
[10:06:54] Show important messages [completed]
Command server:deploy has completed successfully in 03:02.

Good job, @mmorhun !

@openshift-merge-robot
Copy link

@mmorhun: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v6-che-operator-single-host-nightly-deployment 40cd077 link /test v6-che-operator-single-host-nightly-deployment
ci/prow/v7-che-operator-single-host-nightly-deployment 40cd077 link /test v7-che-operator-single-host-nightly-deployment
ci/prow/v7-che-operator-olm-nightly-deployment 40cd077 link /test v7-che-operator-olm-nightly-deployment

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mmorhun mmorhun merged commit b1a756d into master Jan 19, 2021
@mmorhun mmorhun deleted the che-18828 branch January 19, 2021 16:17
@che-bot che-bot added this to the 7.25 milestone Jan 19, 2021
@tolusha tolusha mentioned this pull request Jan 20, 2021
Closed
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@tolusha tolusha tolusha approved these changes

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@flacatus flacatus Awaiting requested review from flacatus

@davidfestal davidfestal Awaiting requested review from davidfestal

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees

@dmytro-ndp dmytro-ndp

@tolusha tolusha

@mmorhun mmorhun

Labels
lgtm
Projects
None yet
Milestone
7.25
7 participants
@mmorhun @openshift-merge-robot @dmytro-ndp @tolusha @AndrienkoAleksandr @openshift-ci-robot @che-bot