-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use architecture dependent images #398
Conversation
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
/test v5-che-operator-olm-latest-changes-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now we only need the keycloak (RH-SSO) image to be named differently by arch, but this solution should work for ANY images we have to use in future which are openjdk/openj9 differentiated, even plugin & devfile registries, which right now are planned to be built with different references inside them, rather than being differently-named images.
Thus quay.io/crw/pluginregistry-rhel8:2.4 will have:
- for x, references to EAP and XP images w/ openjdk
- for z & p, references to EAP and XP images with openj9
(but the published containers will all have the same name/tag in OSBS/RHCC/Quay)
So... +1, as this should unblock us from moving to the bundle format for operator-metadata and enable x/z/p arches too.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nickboldt, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Once this is merged for Che 7.18, the followup work for CRW 2.4 would be to:
into the csv for CRW 2.4. Correct? |
/retest |
@nickboldt |
Signed-off-by: Anatolii Bazko [email protected]
Reference issue
https://issues.redhat.com/browse/CRW-1131
What does this PR do
Using architecture dependent images.