Fallback to default Che secret name if none is given in case of turned on tls #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d on tls Signed-off-by: Mykola Morhun <[email protected]>
mmorhun
requested review from
davidfestal,
tolusha,
sleshchenko and
AndrienkoAleksandr
mmorhun
requested review from
l0rd,
nickboldt,
rhopp and
vparfonov
as code owners
tolusha
approved these changes
Mar 12, 2020
45 tasks
| tlsSecretName := cr.Spec.K8s.TlsSecretName | ||
| // If TLS is turned on but the secret is not set, try to use Che default value as k8s cluster defaults will not work. | ||
| tlsFlag, _ := strconv.ParseBool(tls) | ||
| if tlsFlag && tlsSecretName == "" { |
There was a problem hiding this comment.
You can also use util.GetValue(stringFromCR, defaultStringValue)
Than code could be:
tlsSecretName := cr.Spec.K8s.TlsSecretName
tlsFlag, _ := strconv.ParseBool(tls)
if tlsFlag {
tlsSecretName = util.getValue(tlsSecretName, "che-tls")
}
But it's optional, up to you.
AndrienkoAleksandr
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Morhun [email protected]
What does this PR do?
Uses default
che-tlssecret name for securing Che ingresses if TLS is turned on andtlsSecretNameis not provided in Che CR.What issues does this PR fix or reference?
eclipse-che/che#16280