Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes devfile-registry deployment component #1876

Merged
merged 3 commits into from
Aug 7, 2024
Merged

chore: Removes devfile-registry deployment component #1876

merged 3 commits into from
Aug 7, 2024

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Aug 5, 2024

What does this PR do?

  • Remove plugin-registry deployment and related kubernetes resources
  • Add ``https://registry.devfile.io to the list of external devfile registries

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#23026

How to test this PR?

  1. Prepare a patch file if needed:
cat > /tmp/cr-patch.yaml <<EOF
apiVersion: org.eclipse.che/v2
kind: CheCluster
spec: {}
EOF
  1. Deploy the operator:

OpenShift

./build/scripts/olm/test-catalog-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

on Minikube

./build/scripts/minikube-tests/test-operator-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@tolusha tolusha requested review from SDawley and ibuziuk as code owners August 5, 2024 09:57
@tolusha
Copy link
Contributor Author

tolusha commented Aug 6, 2024

/retest

@tolusha
Copy link
Contributor Author

tolusha commented Aug 6, 2024

/restart

Copy link

openshift-ci bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Aug 7, 2024
Copy link

openshift-ci bot commented Aug 7, 2024

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Aug 7, 2024

@tolusha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-che-behind-proxy 082dde9 link true /test v14-che-behind-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tolusha tolusha changed the title chore: Clean up devfile registry deployment chore: Removes plugin-registry deployment component Aug 7, 2024
@tolusha tolusha merged commit 2683310 into main Aug 7, 2024
20 of 21 checks passed
@tolusha tolusha deleted the 23026_2 branch August 7, 2024 12:27
@devstudio-release
Copy link

Build 3.16 :: operator_3.x/382: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.16 :: operator_3.x/382: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7368 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.16 :: copyIIBsToQuay/2742: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7365: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 63193141 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7366: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 63193200 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7369: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 63193739 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.16 :: operator-bundle_3.16/1: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.16 :: copyIIBsToQuay/2744: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: sync-to-downstream_3.16/1: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.16/1 triggered; /job/DS_CI/job/dsc_3.16 triggered;

@devstudio-release
Copy link

Build 3.16 :: operator-bundle_3.16/1: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.16/1 triggered

@devstudio-release
Copy link

Build 3.16 :: dsc_3.16/1: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: dsc_3.16/1: SUCCESS

3.16.0-CI

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7370: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 63195175 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7371: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 63200979 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@tolusha tolusha changed the title chore: Removes plugin-registry deployment component chore: Removes devfile-registry deployment component Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants