-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support single-user mode #185
Conversation
Signed-off-by: Anatoliy Bazko <[email protected]>
pkg/deploy/deployment_che.go
Outdated
Name: DefaultCheVolumeName, | ||
VolumeSource: corev1.VolumeSource{ | ||
PersistentVolumeClaim: &corev1.PersistentVolumeClaimVolumeSource{ | ||
ClaimName: DefaultCheVolumeName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be called DefaultCheVolumeClaimName, because we don't create volume itself. che-operator creates volumeClaim and infra provide real volume for us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I see, we are using the same name for volume and claim, so let it be.
spec:
server:
customCheProperties:
CHE_MULTIUSER: "false" Single/Multi-user mode is not a custom property but kind of fundamental settings because it influences not the only |
This comment has been minimized.
This comment has been minimized.
@tolusha Do we need OLM artifacts for this pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with minikube, minishift, CRC. Single and Multi user installation works fine.
@sleshchenko One more point |
@tolusha If we don't want to support SingleUser Che officially by operator - then I'm totally OK with hiding such an ability in customCheProperties. |
@l0rd spec:
server:
customCheProperties:
CHE_MULTIUSER: "false" wdyt? |
Signed-off-by: Anatoliy Bazko [email protected]
Reference issue
eclipse-che/che#13420
How to deploy single user:
CR resource should contains: