Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support single-user mode #185

Merged
merged 4 commits into from
Mar 17, 2020
Merged

Support single-user mode #185

merged 4 commits into from
Mar 17, 2020

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Mar 4, 2020

Signed-off-by: Anatoliy Bazko [email protected]

Reference issue

eclipse-che/che#13420

How to deploy single user:

CR resource should contains:

spec:
  server:
    customCheProperties:
       CHE_MULTIUSER: "false"

Signed-off-by: Anatoliy Bazko <[email protected]>
Name: DefaultCheVolumeName,
VolumeSource: corev1.VolumeSource{
PersistentVolumeClaim: &corev1.PersistentVolumeClaimVolumeSource{
ClaimName: DefaultCheVolumeName,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be called DefaultCheVolumeClaimName, because we don't create volume itself. che-operator creates volumeClaim and infra provide real volume for us.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I see, we are using the same name for volume and claim, so let it be.

@tolusha tolusha mentioned this pull request Mar 5, 2020
46 tasks
@sleshchenko
Copy link
Member

spec:
  server:
    customCheProperties:
       CHE_MULTIUSER: "false"

Single/Multi-user mode is not a custom property but kind of fundamental settings because it influences not the only server but also database and auth sections, actually singleUser mode makes that sections ignored, right?
So, please consider moving multi-user property to server level, or even on root spec.

@tolusha

This comment has been minimized.

@AndrienkoAleksandr
Copy link
Contributor

@tolusha Do we need OLM artifacts for this pr?

@tolusha
Copy link
Contributor Author

tolusha commented Mar 5, 2020

@AndrienkoAleksandr
no

@tolusha tolusha mentioned this pull request Mar 5, 2020
45 tasks
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with minikube, minishift, CRC. Single and Multi user installation works fine.

@tolusha
Copy link
Contributor Author

tolusha commented Mar 5, 2020

@sleshchenko One more point
Single user mode isn't supported

@sleshchenko
Copy link
Member

Single user mode isn't supported

@tolusha If we don't want to support SingleUser Che officially by operator - then I'm totally OK with hiding such an ability in customCheProperties.

@tolusha
Copy link
Contributor Author

tolusha commented Mar 6, 2020

@l0rd
This pr allows to install Che in single user mode by operator.
The main goal of the PR is to deprecate completely deploy.sh script.
That's why I would like to "hide" this functionality in customCheProperties like this and not document at all.

spec:
  server:
    customCheProperties:
       CHE_MULTIUSER: "false"

wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants