-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DevWorkspace Operator dependency to v0.25.0 #1805
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1805 +/- ##
=======================================
Coverage 59.73% 59.73%
=======================================
Files 74 74
Lines 9102 9102
=======================================
Hits 5437 5437
Misses 3290 3290
Partials 375 375 ☔ View full report in Codecov by Sentry. |
629ea8c
to
61e4e48
Compare
Signed-off-by: Angel Misevski <[email protected]>
Signed-off-by: Angel Misevski <[email protected]>
61e4e48
to
dc28a2a
Compare
@amisevsk: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
To update the DWO dependency, all we need to do is update the version in After vendoring, it's necessary to look for any changed dependencies (transitive dependencies of DWO) and update DEPENDENCIES.md with the new versions + links to clearlydefined/similar to validate licensing. You can see the entirety of the manual changes in the first commit in this PR: bd0e50f. The second commit is just the result of running @tolusha is more familiar with this process for the Che Operator than I am. |
@AObuchow: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Leaving this open for Anatolii to review and merge, since I'm not 100% I got every step of the process |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, AObuchow, ibuziuk, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.12 :: operator_3.x/346: Console, Changes, Git Data |
Build 3.12 :: sync-to-downstream_3.x/6132: Console, Changes, Git Data |
Build 3.12 :: push-latest-container-to-quay_3.x/4280: Console, Changes, Git Data |
Build 3.12 :: get-sources-rhpkg-container-build_3.x/6029: devspaces-operator : 3.x :: Build 58585748 : quay.io/devspaces/devspaces-rhel8-operator:3.12-17 |
Build 3.12 :: update-digests_3.x/5730: Console, Changes, Git Data |
Build 3.12 :: operator_3.x/346: Upstream sync done; /DS_CI/sync-to-downstream_3.x/6132 triggered |
Build 3.12 :: operator-bundle_3.x/2599: Console, Changes, Git Data |
Build 3.12 :: sync-to-downstream_3.x/6133: Console, Changes, Git Data |
Build 3.12 :: get-sources-rhpkg-container-build_3.x/6030: devspaces-operator-bundle : 3.x :: Failed in 58586154 : BREW:BUILD/STATUS:UNKNOWN |
Build 3.12 :: operator-bundle_3.x/2600: Console, Changes, Git Data |
Build 3.12 :: sync-to-downstream_3.x/6134: Console, Changes, Git Data |
Build 3.12 :: get-sources-rhpkg-container-build_3.x/6031: devspaces-operator-bundle : 3.x :: Failed in 58588744 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
Updates the DevWorkspace Operator dependency to
v0.25.0
. This also pulls in devfile/apiv2.2.2
.Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
General maintenance
Fixes eclipse-che/che#22068
How to test this PR?
Functionally should be no changes except eclipse-che/che#22068 is resolved
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.