chore: update to DevWorkspace-Operator 0.20.0

[AObuchow]

What does this PR do?

Updates the DevWorkspace-Operator dependency to v0.20.0 as well as transitive dependencies, required for #1643.

Also replaces usages of corev1.Handler (now deprecated) to corev1.ProbeHandler

Screenshot/screencast of this PR

n/a

What issues does this PR fix or reference?

Required step for eclipse-che/che#22012

How to test this PR?

n/a

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• Development resource are up to date
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[openshift-ci]

Hi @AObuchow. Thanks for your PR.

I'm waiting for a eclipse-che member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AObuchow

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #1659 (c7f6306) into main (a1bb81f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1659   +/-   ##
=======================================
  Coverage   58.67%   58.67%           
=======================================
  Files          72       72           
  Lines        8406     8406           
=======================================
  Hits         4932     4932           
  Misses       3143     3143           
  Partials      331      331           

Impacted Files	Coverage Δ
pkg/deploy/dashboard/deployment_dashboard.go	98.56% <100.00%> (ø)
pkg/deploy/server/server_deployment.go	82.60% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[AObuchow]

@tolusha I apologize for the failing CI tests. I've tried to figure out the scheme issue with no success, so far. However, it seems to be reproducible locally on Minikube (by running build/scripts/minikube-tests/test-operator.sh) and also occurs on OpenShift 4.12 when I manually install the catalogsource for devworkspace-operator (built off of the main DWO branch) and install Che with build/scripts/olm/test-catalog-from-sources.sh.

When I inspected the DWO logs on OpenShift, I saw the following (which wasn't occurring when DWO was installed alone):

E0412 23:56:37.930808 1 reflector.go:140] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: Failed to watch *v1alpha2.DevWorkspaceTemplate: an error on the server ("unknown") has prevented the request from succeeding (get devworkspacetemplates.workspace.devfile.io)
E0412 23:56:39.549055 1 reflector.go:140] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: Failed to watch *v1alpha2.DevWorkspace: an error on the server ("unknown") has prevented the request from succeeding (get devworkspaces.workspace.devfile.io)
W0412 23:56:41.196106 1 reflector.go:424] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: failed to list *v1alpha2.DevWorkspaceTemplate: Internal error occurred: error resolving resource
E0412 23:56:41.196152 1 reflector.go:140] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: Failed to watch *v1alpha2.DevWorkspaceTemplate: failed to list *v1alpha2.DevWorkspaceTemplate: Internal error occurred: error resolving resource
W0412 23:56:42.147994 1 reflector.go:424] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: failed to list *v1alpha2.DevWorkspace: Internal error occurred: error resolving resource
E0412 23:56:42.148038 1 reflector.go:140] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: Failed to watch *v1alpha2.DevWorkspace: failed to list *v1alpha2.DevWorkspace: Internal error occurred: error resolving resource
W0412 23:56:45.045462 1 reflector.go:424] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: failed to list *v1alpha2.DevWorkspaceTemplate: Internal error occurred: error resolving resource
E0412 23:56:45.045498 1 reflector.go:140] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: Failed to watch *v1alpha2.DevWorkspaceTemplate: failed to list *v1alpha2.DevWorkspaceTemplate: Internal error occurred: error resolving resource
W0412 23:56:46.233914 1 reflector.go:424] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: failed to list *v1alpha2.DevWorkspace: Internal error occurred: error resolving resource
E0412 23:56:46.233962 1 reflector.go:140] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: Failed to watch *v1alpha2.DevWorkspace: failed to list *v1alpha2.DevWorkspace: Internal error occurred: error resolving resource
W0412 23:56:55.140617 1 reflector.go:424] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: failed to list *v1alpha2.DevWorkspaceTemplate: Internal error occurred: error resolving resource
E0412 23:56:55.140676 1 reflector.go:140] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: Failed to watch *v1alpha2.DevWorkspaceTemplate: failed to list *v1alpha2.DevWorkspaceTemplate: Internal error occurred: error resolving resource
W0412 23:56:55.694693 1 reflector.go:424] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: failed to list *v1alpha2.DevWorkspace: Internal error occurred: error resolving resource
E0412 23:56:55.694729 1 reflector.go:140] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: Failed to watch *v1alpha2.DevWorkspace: failed to list *v1alpha2.DevWorkspace: Internal error occurred: error resolving resource
E0412 23:57:14.550257 1 reflector.go:140] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: Failed to watch *v1alpha2.DevWorkspace: an error on the server ("unknown") has prevented the request from succeeding (get devworkspaces.workspace.devfile.io)
W0412 23:57:16.934021 1 reflector.go:424] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: failed to list *v1alpha2.DevWorkspaceTemplate: Internal error occurred: error resolving resource
E0412 23:57:16.934059 1 reflector.go:140] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: Failed to watch *v1alpha2.DevWorkspaceTemplate: failed to list *v1alpha2.DevWorkspaceTemplate: Internal error occurred: error resolving resource
W0412 23:57:42.858738 1 reflector.go:424] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: failed to list *v1alpha2.DevWorkspace: Internal error occurred: error resolving resource
E0412 23:57:42.858793 1 reflector.go:140] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: Failed to watch *v1alpha2.DevWorkspace: failed to list *v1alpha2.DevWorkspace: Internal error occurred: error resolving resource
W0412 23:57:59.731932 1 reflector.go:424] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: failed to list *v1alpha2.DevWorkspaceTemplate: Internal error occurred: error resolving resource
E0412 23:57:59.731968 1 reflector.go:140] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: Failed to watch *v1alpha2.DevWorkspaceTemplate: failed to list *v1alpha2.DevWorkspaceTemplate: Internal error occurred: error resolving resource
W0412 23:58:21.274573 1 reflector.go:424] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: failed to list *v1alpha2.DevWorkspace: Internal error occurred: error resolving resource
E0412 23:58:21.274624 1 reflector.go:140] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:169: Failed to watch *v1alpha2.DevWorkspace: failed to list *v1alpha2.DevWorkspace: Internal error occurred: error resolving resource

I currently suspect there might be a mismatch between a dependency used by DWO and Che-Operator.
I thought it was client-go but both DWO and my PR use client-go v0.26.1 (Unless I missed something..)

I also don't see any issues about the DWO scheme not being installed properly in the Che-Operator logs.

If you have some time to investigate, please let me know if you find what's causing the problem. I will continue working on this tomorrow as soon as possible.

[tolusha]

Closed in favor of #1660