Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove PostgreSQL component #1630

Merged
merged 5 commits into from
Feb 28, 2023
Merged

feat: Remove PostgreSQL component #1630

merged 5 commits into from
Feb 28, 2023

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Feb 23, 2023

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #1630 (8c710eb) into main (8d0ee22) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1630      +/-   ##
==========================================
- Coverage   58.33%   58.10%   -0.24%     
==========================================
  Files          73       70       -3     
  Lines        8530     8177     -353     
==========================================
- Hits         4976     4751     -225     
+ Misses       3219     3106     -113     
+ Partials      335      320      -15     
Impacted Files Coverage Δ
api/v2/checluster_types.go 30.76% <ø> (ø)
pkg/common/operator-defaults/defaults.go 18.07% <ø> (+1.66%) ⬆️
pkg/deploy/server/server_configmap.go 70.53% <ø> (-0.56%) ⬇️
pkg/deploy/server/server_deployment.go 82.60% <ø> (+0.45%) ⬆️
pkg/deploy/postgres/postgres.go

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tolusha
Copy link
Contributor Author

tolusha commented Feb 27, 2023

/retest

@@ -302,6 +302,7 @@ type DevfileRegistry struct {
ExternalDevfileRegistries []ExternalDevfileRegistry `json:"externalDevfileRegistries,omitempty"`
}

// Database component is Deprecated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should add a note that not only it is deprecated but that all the properties set on CR level will be ignored

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

// Database component is Deprecated. All properties will be ignored.

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup job 👍

@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Feb 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2023

New changes are detected. LGTM label has been removed.

Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
@tolusha
Copy link
Contributor Author

tolusha commented Feb 28, 2023

/retest

@tolusha tolusha merged commit 12169de into main Feb 28, 2023
@tolusha tolusha deleted the 21374 branch February 28, 2023 13:42
@devstudio-release
Copy link

Build 3.6 :: operator_3.x/198: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@che-bot che-bot added this to the 7.62 milestone Feb 28, 2023
@devstudio-release
Copy link

Build 3.6 :: operator-bundle_3.x/968: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.6 :: operator-bundle_3.x/969: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.6 :: update-digests_3.x/2347: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: operator-bundle_3.x/970: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.6 :: operator-bundle_3.x/971: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.6 :: copyIIBsToQuay/1080: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: push-latest-container-to-quay_3.x/1853: SUCCESS

Copied: devspaces-operator-bundle; bundle-generated updated;
/job/DS_CI/job/Releng/job/copyIIBsToQuay triggered for OCP v4.13 v4.12 v4.11 v4.10

@devstudio-release
Copy link

Build 3.6 :: sync-to-downstream_3.x/2569: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/2446 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.6 :: operator-bundle_3.x/971: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/2569 triggered

@devstudio-release
Copy link

Build 3.6 :: copyIIBsToQuay/1080: SUCCESS

3.6
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.6-72
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.19-4
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.6-v4.13-443587-440885-s390x
  + quay.io/devspaces/iib:3.6-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.6-v4.12-443582-440880-s390x
  + quay.io/devspaces/iib:3.6-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
  + quay.io/devspaces/iib:3.6-v4.11-443571-440871-s390x
  + quay.io/devspaces/iib:3.6-v4.11-s390x
  + quay.io/devspaces/iib:next-v4.11-s390x
  + quay.io/devspaces/iib:3.6-v4.10-443616-440866-s390x
  + quay.io/devspaces/iib:3.6-v4.10-s390x
  + quay.io/devspaces/iib:next-v4.10-s390x
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.6-v4.13-443587-440885-ppc64le
  + quay.io/devspaces/iib:3.6-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.6-v4.12-443582-440880-ppc64le
  + quay.io/devspaces/iib:3.6-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le
  + quay.io/devspaces/iib:3.6-v4.11-443571-440871-ppc64le
  + quay.io/devspaces/iib:3.6-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le
  + quay.io/devspaces/iib:3.6-v4.10-443616-440866-ppc64le
  + quay.io/devspaces/iib:3.6-v4.10-ppc64le
  + quay.io/devspaces/iib:next-v4.10-ppc64le
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.6-v4.13-443587-440885-x86_64
  + quay.io/devspaces/iib:3.6-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.6-v4.12-443582-440880-x86_64
  + quay.io/devspaces/iib:3.6-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
  + quay.io/devspaces/iib:3.6-v4.11-443624-440871-x86_64
  + quay.io/devspaces/iib:3.6-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64
  + quay.io/devspaces/iib:3.6-v4.10-443616-440866-x86_64
  + quay.io/devspaces/iib:3.6-v4.10-x86_64
  + quay.io/devspaces/iib:next-v4.10-x86_64

@devstudio-release
Copy link

Build 3.6 :: operator-bundle_3.x/972: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.6 :: copyIIBsToQuay/1082: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: push-latest-container-to-quay_3.x/1855: SUCCESS

Copied: devspaces-operator-bundle; bundle-generated updated;
/job/DS_CI/job/Releng/job/copyIIBsToQuay triggered for OCP v4.13 v4.12 v4.11 v4.10

@devstudio-release
Copy link

Build 3.6 :: sync-to-downstream_3.x/2572: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/2448 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.6 :: operator-bundle_3.x/972: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/2572 triggered

@devstudio-release
Copy link

Build 3.6 :: operator-bundle_3.x/974: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants