Apply git self-signed SSL certs #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Igor Vinokur <[email protected]>
|
@vinokurig |
|
@tolusha |
tolusha
reviewed
Dec 24, 2019
| ConfigMapKeyRef: &corev1.ConfigMapKeySelector{ | ||
| Key: "githost", | ||
| LocalObjectReference: corev1.LocalObjectReference{ | ||
| Name: "che-git-self-signed-cert", |
There was a problem hiding this comment.
It is the same name as above.
Is it correct?
There was a problem hiding this comment.
yes, it uses the same config-map, but another key
nickboldt
pushed a commit
to nickboldt/che-operator
that referenced
this pull request
Jan 31, 2020
Add new boolean property gitSelfSignedCertthat applies environment variables that contain SSL certificate and git host written from che-git-self-signed-cert config map. The same logic is applied for the helm deployment: eclipse-che/che#15218 fixes eclipse-che/che#15285 Docs PR: eclipse-che/che-docs#1001 Signed-off-by: Igor Vinokur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new boolean property
gitSelfSignedCertthat applies environment variables that contain SSL certificate and git host written fromche-git-self-signed-certconfig map.The same logic is applied for the helm deployment: eclipse-che/che#15218
fixes eclipse-che/che#15285
Docs PR: eclipse-che/che-docs#1001